From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19621 invoked by alias); 27 Dec 2011 14:35:50 -0000 Received: (qmail 19561 invoked by uid 22791); 27 Dec 2011 14:35:49 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_DB X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Dec 2011 14:35:35 +0000 Received: by iacb35 with SMTP id b35so22015834iac.0 for ; Tue, 27 Dec 2011 06:35:35 -0800 (PST) Received: by 10.42.174.198 with SMTP id w6mr1797324icz.37.1324996535043; Tue, 27 Dec 2011 06:35:35 -0800 (PST) Received: from [192.168.1.103] ([218.109.117.104]) by mx.google.com with ESMTPS id j3sm90721678ibj.1.2011.12.27.06.35.32 (version=SSLv3 cipher=OTHER); Tue, 27 Dec 2011 06:35:34 -0800 (PST) Message-ID: <4EF9D8B4.4050601@gmail.com> Date: Tue, 27 Dec 2011 16:26:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Improve gdb_realpath for Windows hosts References: <1324574084-7971-1-git-send-email-brobecker@adacore.com> <4EF9B94C.7030204@gmail.com> <20111227124009.GG23376@adacore.com> <4EF9D06E.7080008@gmail.com> <20111227141214.GH23376@adacore.com> In-Reply-To: <20111227141214.GH23376@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00843.txt.bz2 On 2011-12-27 22:12, Joel Brobecker wrote: >> Can you explain that why you avoid converting to lowercase? >> >>> /* The file system is case-insensitive but case-preserving. >>> So we do not lowercase the path. Otherwise, we might not >>> be able to display the original casing in a given path. */ >> I just thought that lowercase is another canonization of path, so you >> can have a uniform path when you set breakpoints(file specification) > Two reasons, mostly: > . It is unnecessary; > . It changes the filename casing when displaying the name of > the file where the breakpoint has been inserted. > > Several Windows users at AdaCore often complain that GNU tools do not > properly preserve the filename casing, so I did not think it was > proper for us to do so. Even as a Unix user, I do feel that it is > important to preserve the casing as well. > > I should say that it does not affect filename matching, which is > performed through another specialized function. > >> The original code in iberty library is like: > Honestly, I do not understand why they do it. There is no correlation, > IMO, between the fact that the FS is case-insensitive and the fact > that you'd want to change the filename casing (again, doing something > extra which is unnecessary, since it does not make a difference to > the filesystem). > OK, I understand now. Thank you Joel for your explanation and your time. asmwarrior ollydbg from codeblocks' forum