From: Sanjoy Das <sanjoy@playingwithpointers.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Stan Shebs <stanshebs@earthlink.net>
Subject: Re: Regression for gdb.base/jit.exp and gdb.base/jit-so.exp [Re: JIT Interface Patches Landed]
Date: Tue, 29 Nov 2011 08:33:00 -0000 [thread overview]
Message-ID: <4ED499B6.8030102@playingwithpointers.com> (raw)
In-Reply-To: <20111127185941.GA6811@host1.jankratochvil.net>
[-- Attachment #1: Type: text/plain, Size: 124 bytes --]
> Could you review these comments there?
I've checked in the attached patch.
--
Sanjoy Das
http://playingwithpointers.com
[-- Attachment #2: comments.diff --]
[-- Type: text/x-diff, Size: 1587 bytes --]
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c759514..a8d71f4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2011-11-29 Sanjoy Das <sdas@igalia.com>
+
+ * jit.c (add_objfile_entry, jit_reader_try_read_symtab)
+ (jit_bfd_try_read_symtab): Fix comments.
+
2011-11-28 DJ Delorie <dj@redhat.com>
* NEWS: Mention RL78 simulator.
diff --git a/gdb/jit.c b/gdb/jit.c
index 099f79d..843c768 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -239,7 +239,8 @@ struct jit_inferior_data
CORE_ADDR descriptor_addr; /* &__jit_debug_descriptor */
};
-/* Remember a mapping from entry_addr to objfile. */
+/* Remember OBJFILE has been created for struct jit_code_entry located
+ at inferior address ENTRY. */
static void
add_objfile_entry (struct objfile *objfile, CORE_ADDR entry)
@@ -711,8 +712,8 @@ jit_object_close_impl (struct gdb_symbol_callbacks *cb,
}
/* Try to read CODE_ENTRY using the loaded jit reader (if any).
- ENTRY_ADDR is the address of the object file (in the target's
- address space) being read. */
+ ENTRY_ADDR is the address of the struct jit_code_entry in the
+ inferior address space. */
static int
jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
@@ -769,7 +770,7 @@ jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
}
/* Try to read CODE_ENTRY using BFD. ENTRY_ADDR is the address of the
- object file (in the target's address space) being read. */
+ struct jit_code_entry in the inferior address space. */
static void
jit_bfd_try_read_symtab (struct jit_code_entry *code_entry,
next prev parent reply other threads:[~2011-11-29 8:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 10:09 JIT Interface Patches Landed Sanjoy Das
2011-11-21 4:06 ` Stan Shebs
2011-11-26 0:23 ` Regression for gdb.base/jit.exp and gdb.base/jit-so.exp [Re: JIT Interface Patches Landed] Jan Kratochvil
2011-11-26 13:13 ` Sanjoy Das
2011-11-27 10:53 ` Jan Kratochvil
2011-11-27 14:27 ` Sanjoy Das
2011-11-27 14:30 ` Jan Kratochvil
2011-11-27 14:38 ` Sanjoy Das
2011-11-27 14:41 ` Sanjoy Das
2011-11-27 18:29 ` Joel Brobecker
2011-11-27 18:56 ` Sanjoy Das
2011-11-27 19:00 ` Jan Kratochvil
2011-11-29 8:33 ` Sanjoy Das [this message]
2011-11-29 16:37 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED499B6.8030102@playingwithpointers.com \
--to=sanjoy@playingwithpointers.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox