Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org, Stan Shebs <stanshebs@earthlink.net>
Subject: Re: Regression for gdb.base/jit.exp and gdb.base/jit-so.exp  [Re: JIT Interface Patches Landed]
Date: Sun, 27 Nov 2011 19:00:00 -0000	[thread overview]
Message-ID: <20111127185941.GA6811@host1.jankratochvil.net> (raw)
In-Reply-To: <4ED24C58.1090300@playingwithpointers.com>

On Sun, 27 Nov 2011 15:42:32 +0100, Sanjoy Das wrote:
> -/* Try to read CODE_ENTRY using the loaded jit reader (if any).  */
> +/* Try to read CODE_ENTRY using the loaded jit reader (if any).
> +   ENTRY_ADDR is the address of the object file (in the target's
> +   address space) being read.  */
>  
>  static int
> -jit_reader_try_read_symtab (struct jit_code_entry *code_entry)
> +jit_reader_try_read_symtab (struct jit_code_entry *code_entry,
> +                            CORE_ADDR entry_addr)

The problem is ENTRY_ADDR is not the object file address.

SYMFILE_ADDR is the object file address.  ENTRY_ADDR is the address of the
inferior struct jit_code_entry.  The bug was these two can be different.

Also the comment
	/* Remember a mapping from entry_addr to objfile.  */

	static void
	add_objfile_entry (struct objfile *objfile, CORE_ADDR entry)

is not saying much, there should be something like:
	/* Remember OBJFILE has been created for struct jit_code_entry located
	   at inferior address ENTRY.  */

Could you review these comments there?


Thanks,
Jan


  parent reply	other threads:[~2011-11-27 19:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-20 10:09 JIT Interface Patches Landed Sanjoy Das
2011-11-21  4:06 ` Stan Shebs
2011-11-26  0:23   ` Regression for gdb.base/jit.exp and gdb.base/jit-so.exp [Re: JIT Interface Patches Landed] Jan Kratochvil
2011-11-26 13:13     ` Sanjoy Das
2011-11-27 10:53       ` Jan Kratochvil
2011-11-27 14:27         ` Sanjoy Das
2011-11-27 14:30           ` Jan Kratochvil
2011-11-27 14:38             ` Sanjoy Das
2011-11-27 14:41               ` Sanjoy Das
2011-11-27 18:29                 ` Joel Brobecker
2011-11-27 18:56                   ` Sanjoy Das
2011-11-27 19:00               ` Jan Kratochvil [this message]
2011-11-29  8:33                 ` Sanjoy Das
2011-11-29 16:37                   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111127185941.GA6811@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sanjoy@playingwithpointers.com \
    --cc=stanshebs@earthlink.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox