From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23906 invoked by alias); 27 Nov 2011 19:00:13 -0000 Received: (qmail 23897 invoked by uid 22791); 27 Nov 2011 19:00:12 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Nov 2011 18:59:46 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pARIxjoC004402 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 27 Nov 2011 13:59:45 -0500 Received: from host1.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pARIxhdN019008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 27 Nov 2011 13:59:45 -0500 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id pARIxgGP006975; Sun, 27 Nov 2011 19:59:42 +0100 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id pARIxfkD006974; Sun, 27 Nov 2011 19:59:41 +0100 Date: Sun, 27 Nov 2011 19:00:00 -0000 From: Jan Kratochvil To: Sanjoy Das Cc: gdb-patches@sourceware.org, Stan Shebs Subject: Re: Regression for gdb.base/jit.exp and gdb.base/jit-so.exp [Re: JIT Interface Patches Landed] Message-ID: <20111127185941.GA6811@host1.jankratochvil.net> References: <4EC8D2D4.1080402@playingwithpointers.com> <4EC9CE39.40604@earthlink.net> <20111126002251.GA5257@host1.jankratochvil.net> <4ED0E6F9.8090101@playingwithpointers.com> <20111127105332.GA25259@host1.jankratochvil.net> <4ED249CA.705@playingwithpointers.com> <20111127143036.GA32565@host1.jankratochvil.net> <4ED24C58.1090300@playingwithpointers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ED24C58.1090300@playingwithpointers.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00741.txt.bz2 On Sun, 27 Nov 2011 15:42:32 +0100, Sanjoy Das wrote: > -/* Try to read CODE_ENTRY using the loaded jit reader (if any). */ > +/* Try to read CODE_ENTRY using the loaded jit reader (if any). > + ENTRY_ADDR is the address of the object file (in the target's > + address space) being read. */ > > static int > -jit_reader_try_read_symtab (struct jit_code_entry *code_entry) > +jit_reader_try_read_symtab (struct jit_code_entry *code_entry, > + CORE_ADDR entry_addr) The problem is ENTRY_ADDR is not the object file address. SYMFILE_ADDR is the object file address. ENTRY_ADDR is the address of the inferior struct jit_code_entry. The bug was these two can be different. Also the comment /* Remember a mapping from entry_addr to objfile. */ static void add_objfile_entry (struct objfile *objfile, CORE_ADDR entry) is not saying much, there should be something like: /* Remember OBJFILE has been created for struct jit_code_entry located at inferior address ENTRY. */ Could you review these comments there? Thanks, Jan