From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10052 invoked by alias); 29 Nov 2011 08:33:28 -0000 Received: (qmail 10042 invoked by uid 22791); 29 Nov 2011 08:33:27 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Nov 2011 08:33:10 +0000 Received: by iaek3 with SMTP id k3so12874562iae.0 for ; Tue, 29 Nov 2011 00:33:09 -0800 (PST) Received: by 10.42.163.202 with SMTP id d10mr27622142icy.47.1322555589217; Tue, 29 Nov 2011 00:33:09 -0800 (PST) Received: from [127.0.0.1] ([203.110.240.205]) by mx.google.com with ESMTPS id eb23sm56548492ibb.2.2011.11.29.00.32.57 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Nov 2011 00:33:00 -0800 (PST) Message-ID: <4ED499B6.8030102@playingwithpointers.com> Date: Tue, 29 Nov 2011 08:33:00 -0000 From: Sanjoy Das User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org, Stan Shebs Subject: Re: Regression for gdb.base/jit.exp and gdb.base/jit-so.exp [Re: JIT Interface Patches Landed] References: <4EC8D2D4.1080402@playingwithpointers.com> <4EC9CE39.40604@earthlink.net> <20111126002251.GA5257@host1.jankratochvil.net> <4ED0E6F9.8090101@playingwithpointers.com> <20111127105332.GA25259@host1.jankratochvil.net> <4ED249CA.705@playingwithpointers.com> <20111127143036.GA32565@host1.jankratochvil.net> <4ED24C58.1090300@playingwithpointers.com> <20111127185941.GA6811@host1.jankratochvil.net> In-Reply-To: <20111127185941.GA6811@host1.jankratochvil.net> Content-Type: multipart/mixed; boundary="------------040409010604070003010502" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00806.txt.bz2 This is a multi-part message in MIME format. --------------040409010604070003010502 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 124 > Could you review these comments there? I've checked in the attached patch. -- Sanjoy Das http://playingwithpointers.com --------------040409010604070003010502 Content-Type: text/x-diff; name="comments.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="comments.diff" Content-length: 1587 diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c759514..a8d71f4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2011-11-29 Sanjoy Das + + * jit.c (add_objfile_entry, jit_reader_try_read_symtab) + (jit_bfd_try_read_symtab): Fix comments. + 2011-11-28 DJ Delorie * NEWS: Mention RL78 simulator. diff --git a/gdb/jit.c b/gdb/jit.c index 099f79d..843c768 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -239,7 +239,8 @@ struct jit_inferior_data CORE_ADDR descriptor_addr; /* &__jit_debug_descriptor */ }; -/* Remember a mapping from entry_addr to objfile. */ +/* Remember OBJFILE has been created for struct jit_code_entry located + at inferior address ENTRY. */ static void add_objfile_entry (struct objfile *objfile, CORE_ADDR entry) @@ -711,8 +712,8 @@ jit_object_close_impl (struct gdb_symbol_callbacks *cb, } /* Try to read CODE_ENTRY using the loaded jit reader (if any). - ENTRY_ADDR is the address of the object file (in the target's - address space) being read. */ + ENTRY_ADDR is the address of the struct jit_code_entry in the + inferior address space. */ static int jit_reader_try_read_symtab (struct jit_code_entry *code_entry, @@ -769,7 +770,7 @@ jit_reader_try_read_symtab (struct jit_code_entry *code_entry, } /* Try to read CODE_ENTRY using BFD. ENTRY_ADDR is the address of the - object file (in the target's address space) being read. */ + struct jit_code_entry in the inferior address space. */ static void jit_bfd_try_read_symtab (struct jit_code_entry *code_entry, --------------040409010604070003010502--