From: Michael Eager <eager@eagerm.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: SEGV in dwarf2read.c -- gdb-7.2
Date: Thu, 03 Nov 2011 17:37:00 -0000 [thread overview]
Message-ID: <4EB2D12E.2010900@eagerm.com> (raw)
In-Reply-To: <20111103172232.GA23268@host1.jankratochvil.net>
On 11/03/2011 10:22 AM, Jan Kratochvil wrote:
> On Thu, 03 Nov 2011 18:13:04 +0100, Michael Eager wrote:
>> With the addition of the call to age_cached_comp_units() in
>> dwarf2_fetch_die_location_block() and dw2_do_instantiate_symtab(),
>> I think that the cache is aged very aggressively.
>
>> With dwarf2_max_cache_age == 5, it looks to me that it is likely that CU
>> data will not be in the cache when needed.
>
> There was for example this fix:
> http://sourceware.org/ml/gdb-patches/2011-07/msg00495.html
>
> which is not yet even in 7.3.1 as I see now, it is only in FSF GDB HEAD.
Thanks. The patch looks similar to the one I came up with. I added
a similar check higher in the call tree.
> wrt CUs aging therefore only FSF GDB HEAD matters, older releases are known to
> be buggy - at least due to this bug.
>
> With FSF GDB HEAD I am not aware of any problems because any call to
> age_cached_comp_units is done when CUs are no longer needed anywhere.
>
> I do not discuss here about efficiency of the FSF GDB HEAD solution but I am
> not aware of how it could crash any way.
I'll see if it works with my application.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2011-11-03 17:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 16:12 Michael Eager
2011-11-03 16:20 ` Jan Kratochvil
2011-11-03 16:43 ` Tom Tromey
2011-11-03 16:55 ` Jan Kratochvil
2011-11-03 17:13 ` Michael Eager
2011-11-03 17:22 ` Jan Kratochvil
2011-11-03 17:37 ` Michael Eager [this message]
2011-11-03 17:05 ` Michael Eager
2011-11-03 17:25 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB2D12E.2010900@eagerm.com \
--to=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox