Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Eager <eager@eagerm.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: SEGV in dwarf2read.c -- gdb-7.2
Date: Thu, 03 Nov 2011 17:13:00 -0000	[thread overview]
Message-ID: <4EB2CBA0.7030307@eagerm.com> (raw)
In-Reply-To: <20111103165521.GA16221@host1.jankratochvil.net>

On 11/03/2011 09:55 AM, Jan Kratochvil wrote:
> On Thu, 03 Nov 2011 17:43:20 +0100, Tom Tromey wrote:
>> Does the CU cache serve a useful purpose these days?
>
> You already need to pre-read all the CUs (=load_cu) before starting to parse
> them (=process_queue).  So some multi-CU storage needs to be there.  It is
> true the cache should be at least significantly larger
> (now dwarf2_max_cache_age == 5 generations) to have any effect, if it can have
> any effect.

With the addition of the call to age_cached_comp_units() in
dwarf2_fetch_die_location_block() and dw2_do_instantiate_symtab(),
I think that the cache is aged very aggressively.  With
dwarf2_max_cache_age == 5, it looks to me that it is likely that
CU data will not be in the cache when needed.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


  reply	other threads:[~2011-11-03 17:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-03 16:12 Michael Eager
2011-11-03 16:20 ` Jan Kratochvil
2011-11-03 16:43   ` Tom Tromey
2011-11-03 16:55     ` Jan Kratochvil
2011-11-03 17:13       ` Michael Eager [this message]
2011-11-03 17:22         ` Jan Kratochvil
2011-11-03 17:37           ` Michael Eager
2011-11-03 17:05   ` Michael Eager
2011-11-03 17:25     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB2CBA0.7030307@eagerm.com \
    --to=eager@eagerm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox