Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Michael Eager <eager@eagerm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: SEGV in dwarf2read.c -- gdb-7.2
Date: Thu, 03 Nov 2011 16:20:00 -0000	[thread overview]
Message-ID: <20111103162026.GA12269@host1.jankratochvil.net> (raw)
In-Reply-To: <4EB2BD58.3080003@eagerm.com>

Hello Michael,

sorry but I cannot comment more without a reproducer, such possible fix should
have a regression testcase anyway.  Could you provide a reproducer in some
form even just off-list (so that I can reduce it if it is not completely
public and not so critically secure)?


On Thu, 03 Nov 2011 17:12:08 +0100, Michael Eager wrote:
> I ran into a SEGV in in gdb-7.2

The stable release is 7.3.1, moreover for such development I would find only
FSF GDB HEAD relevant.  I remember several fixes which it may be related to.


> Is there a reason to read the CU header into a temporary data
> area rather than reload it using load_full_comp_unit() which will add it to
> the CU cache?

I guess for performance reasons, the CU header read-in vs. load_full_comp_unit
is a big difference.  There are already some PRs (such as 12828 (a)) where GDB
needlessly expands too many CUs "locking itself" by inacceptable performance.


Thanks,
Jan


  reply	other threads:[~2011-11-03 16:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-03 16:12 Michael Eager
2011-11-03 16:20 ` Jan Kratochvil [this message]
2011-11-03 16:43   ` Tom Tromey
2011-11-03 16:55     ` Jan Kratochvil
2011-11-03 17:13       ` Michael Eager
2011-11-03 17:22         ` Jan Kratochvil
2011-11-03 17:37           ` Michael Eager
2011-11-03 17:05   ` Michael Eager
2011-11-03 17:25     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111103162026.GA12269@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=eager@eagerm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox