[patch] fix ldl testcases on FreeBSD

[patch] fix ldl testcases on FreeBSD

[Andreas Tobler]

Hi all,

the below patch makes the test cases work on *-*-freebsd* where we link 
-ldl. Iow, like on openbsd, we do not add -ldl to the libs.

Is this ok for trunk?

Thanks,
Andreas

2011-09-21  Andreas Tobler  <andreast@fgznet.ch>

	* lib/gdb.exp (gdb_compile): Set rpath for <*-*-freebsd*>.

Index: testsuite/lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.186
diff -u -r1.186 gdb.exp
--- testsuite/lib/gdb.exp	18 Sep 2011 02:36:27 -0000	1.186
+++ testsuite/lib/gdb.exp	21 Sep 2011 16:51:49 -0000
@@ -2233,7 +2233,7 @@
  	      || [istarget *-*-pe*]
  	      || [istarget hppa*-*-hpux*])} {
  	    # Do not need anything.
-	} elseif { [istarget *-*-openbsd*] } {
+	} elseif { [istarget *-*-freebsd*] || [istarget *-*-openbsd*] } {
  	    lappend new_options "ldflags=-Wl,-rpath,${outdir}"
  	} elseif { [istarget arm*-*-symbianelf*] } {
  	    if { $shlib_load } {

Re: [patch] fix ldl testcases on FreeBSD

[Joel Brobecker]

> the below patch makes the test cases work on *-*-freebsd* where we
> link -ldl. Iow, like on openbsd, we do not add -ldl to the libs.
> 
> Is this ok for trunk?

The patch looks OK to me, but the description and ChangeLogs are
misleading. What the patch does is both setting the rpath *and*
removing -ldl from the list of compilation switches.

> 2011-09-21  Andreas Tobler  <andreast@fgznet.ch>
> 
> 	* lib/gdb.exp (gdb_compile): Set rpath for <*-*-freebsd*>.

-- 
Joel

Re: [patch] fix ldl testcases on FreeBSD

[Andreas Tobler]

On 21.09.11 20:14, Joel Brobecker wrote:
>> the below patch makes the test cases work on *-*-freebsd* where we
>> link -ldl. Iow, like on openbsd, we do not add -ldl to the libs.
>>
>> Is this ok for trunk?
>
> The patch looks OK to me, but the description and ChangeLogs are
> misleading. What the patch does is both setting the rpath *and*
> removing -ldl from the list of compilation switches.

You're right. Like this?

2011-09-21  Andreas Tobler  <andreast@fgznet.ch>

	* lib/gdb.exp (gdb_compile): Set rpath and remove -ldl from the
	list of compilation switches for <*-*-freebsd*>.

Thanks,
Andreas

Re: [patch] fix ldl testcases on FreeBSD

[Joel Brobecker]

> 2011-09-21  Andreas Tobler  <andreast@fgznet.ch>
> 
> 	* lib/gdb.exp (gdb_compile): Set rpath and remove -ldl from the
> 	list of compilation switches for <*-*-freebsd*>.
[...]
> Like this?

Yep!  Thank you :)

-- 
Joel