From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26141 invoked by alias); 21 Sep 2011 18:14:33 -0000 Received: (qmail 26133 invoked by uid 22791); 21 Sep 2011 18:14:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Sep 2011 18:14:07 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A32C42BAB3F; Wed, 21 Sep 2011 14:14:06 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6vUrgMjl7V3a; Wed, 21 Sep 2011 14:14:06 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C255F2BAB3E; Wed, 21 Sep 2011 14:14:05 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1FCE6145615; Wed, 21 Sep 2011 14:14:01 -0400 (EDT) Date: Wed, 21 Sep 2011 19:04:00 -0000 From: Joel Brobecker To: Andreas Tobler Cc: gdb-patches@sourceware.org Subject: Re: [patch] fix ldl testcases on FreeBSD Message-ID: <20110921181401.GG17681@adacore.com> References: <4E7A172D.6040004@fgznet.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E7A172D.6040004@fgznet.ch> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00398.txt.bz2 > the below patch makes the test cases work on *-*-freebsd* where we > link -ldl. Iow, like on openbsd, we do not add -ldl to the libs. > > Is this ok for trunk? The patch looks OK to me, but the description and ChangeLogs are misleading. What the patch does is both setting the rpath *and* removing -ldl from the list of compilation switches. > 2011-09-21 Andreas Tobler > > * lib/gdb.exp (gdb_compile): Set rpath for <*-*-freebsd*>. -- Joel