[committed] [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver

[Yao Qi <yao@codesourcery.com>]

On 08/10/2011 10:08 PM, Pedro Alves wrote:
> On Wednesday 10 August 2011 15:03:27, Pedro Alves wrote:
>> On Tuesday 09 August 2011 04:11:33, Yao Qi wrote:
>>> 2011-08-09  Andrew Stubbs <ams@codesourcery.com>
>>>             Yao Qi <yao@codesourcery.com>
>>>
>>>         gdb/
>>>         * remote.c (PACKET_qXfer_fdpic): New enum value.
>>>         (remote_protocol_features): Add qXfer:fdpic:read packet.
>>>         (remote_xfer_partial): Support TARGET_OBJECT_FDPIC.
>>>         (_initialize_remote): Add set/show remote read-fdpic-loadmap command.
>>>         * target.h (enum target_object): Add TARGET_OBJECT_FDPIC.
>>>
>>>         gdb/gdbserver:
>>>         * target.h (struct target_ops): Add read_loadmap.
>>>         * linux-low.c (struct target_loadseg): New type.
>>>         (struct target_loadmap): New type.
>>>         (linux_read_loadmap): New function.
>>>         (linux_target_ops): Add linux_read_loadmap.
>>>         * server.c (handle_query): Support qXfer:fdpic:read packet.
>>>         * win32-low.c (win32_target_ops): Initialize field `read_loadmap' to NULL.
>>>
>>>         gdb/doc/
>>>         * gdb.texinfo : Document qXfer:fdpic:read packet.
>>
>> Thanks.  Looks good to me.
> 
> Oh, just one detail:
> 
>> +  /* Read loadmaps.  Read LEN bytes at OFFSET into a buffer at MYADDR.  */
>> +  int (*read_loadmap) (const char *annex, CORE_ADDR offset,
>> +                            unsigned char *myaddr, unsigned int len);
> 
> ...
> 
>> +  NULL, /* read_fdpic_loadmap */
> 
> Please make those coincide though.
> 

Thanks for the patient review.  Committed.
http://sourceware.org/ml/gdb-cvs/2011-08/msg00069.html
http://sourceware.org/ml/gdb-cvs/2011-08/msg00073.html

-- 
Yao (齐尧)