From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83028-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27459 invoked by alias); 14 Aug 2011 16:11:59 -0000
Received: (qmail 27445 invoked by uid 22791); 14 Aug 2011 16:11:58 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 14 Aug 2011 16:11:42 +0000
Received: (qmail 14579 invoked from network); 14 Aug 2011 16:11:41 -0000
Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 14 Aug 2011 16:11:41 -0000
Message-ID: <4E47F3B9.509@codesourcery.com>
Date: Sun, 14 Aug 2011 16:11:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11
MIME-Version: 1.0
To: gdb-patches@sourceware.org
Subject: [committed] [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver
References: <4E263865.2070100@codesourcery.com> <4E40A565.2020208@codesourcery.com> <201108101503.28057.pedro@codesourcery.com> <201108101508.03546.pedro@codesourcery.com>
In-Reply-To: <201108101508.03546.pedro@codesourcery.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00288.txt.bz2

On 08/10/2011 10:08 PM, Pedro Alves wrote:
> On Wednesday 10 August 2011 15:03:27, Pedro Alves wrote:
>> On Tuesday 09 August 2011 04:11:33, Yao Qi wrote:
>>> 2011-08-09  Andrew Stubbs <ams@codesourcery.com>
>>>             Yao Qi <yao@codesourcery.com>
>>>
>>>         gdb/
>>>         * remote.c (PACKET_qXfer_fdpic): New enum value.
>>>         (remote_protocol_features): Add qXfer:fdpic:read packet.
>>>         (remote_xfer_partial): Support TARGET_OBJECT_FDPIC.
>>>         (_initialize_remote): Add set/show remote read-fdpic-loadmap command.
>>>         * target.h (enum target_object): Add TARGET_OBJECT_FDPIC.
>>>
>>>         gdb/gdbserver:
>>>         * target.h (struct target_ops): Add read_loadmap.
>>>         * linux-low.c (struct target_loadseg): New type.
>>>         (struct target_loadmap): New type.
>>>         (linux_read_loadmap): New function.
>>>         (linux_target_ops): Add linux_read_loadmap.
>>>         * server.c (handle_query): Support qXfer:fdpic:read packet.
>>>         * win32-low.c (win32_target_ops): Initialize field `read_loadmap' to NULL.
>>>
>>>         gdb/doc/
>>>         * gdb.texinfo : Document qXfer:fdpic:read packet.
>>
>> Thanks.  Looks good to me.
> 
> Oh, just one detail:
> 
>> +  /* Read loadmaps.  Read LEN bytes at OFFSET into a buffer at MYADDR.  */
>> +  int (*read_loadmap) (const char *annex, CORE_ADDR offset,
>> +                            unsigned char *myaddr, unsigned int len);
> 
> ...
> 
>> +  NULL, /* read_fdpic_loadmap */
> 
> Please make those coincide though.
> 

Thanks for the patient review.  Committed.
http://sourceware.org/ml/gdb-cvs/2011-08/msg00069.html
http://sourceware.org/ml/gdb-cvs/2011-08/msg00073.html

-- 
Yao (齐尧)