From: Mike Frysinger <vapier@gentoo.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver
Date: Mon, 08 Aug 2011 00:30:00 -0000 [thread overview]
Message-ID: <201108072030.02712.vapier@gentoo.org> (raw)
In-Reply-To: <4E2CF0C6.2060504@codesourcery.com>
[-- Attachment #1: Type: Text/Plain, Size: 678 bytes --]
On Monday, July 25, 2011 00:27:50 Yao Qi wrote:
> On 07/22/2011 10:16 AM, Mike Frysinger wrote:
> >> +#if defined __DSBT__
> >> +static int
> >
> > rather than being tied to the exec format that *gdbserver* is being
> > built as, shouldnt this be bound to the ptrace defines being available
> > ? how abut using "#ifdef PTRACE_GETDSBT" ?
>
> Yeah, that makes sense. Done.
i think you missed a spot. one place uses __DSBT__ while another uses
PTRACE_GETDSBT.
> + addr= (int) PTRACE_GETDSBT_EXEC;
> + else if (strcmp (annex, "interp") == 0)
> + addr =(int) PTRACE_GETDSBT_INTERP;
there needs to be one space before and after the "=" here
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-08-08 0:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 2:09 Yao Qi
2011-07-20 14:32 ` Tom Tromey
2011-07-21 7:32 ` [RFA 9/8] New port: TI C6x: Document on qXfer:fdpic:read packet Yao Qi
2011-07-22 12:22 ` [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver Mike Frysinger
2011-07-25 7:23 ` Yao Qi
2011-08-03 1:29 ` ping: " Yao Qi
2011-08-03 8:59 ` Eli Zaretskii
2011-08-08 0:30 ` Mike Frysinger [this message]
2011-08-08 2:47 ` Yao Qi
2011-08-08 8:30 ` Mark Kettenis
2011-08-08 13:05 ` Yao Qi
2011-08-08 14:01 ` Mark Kettenis
2011-08-08 13:32 ` Pedro Alves
2011-08-09 3:12 ` Yao Qi
2011-08-10 12:37 ` Mark Kettenis
2011-08-10 14:03 ` Pedro Alves
2011-08-10 14:08 ` Pedro Alves
2011-08-14 16:11 ` [committed] " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108072030.02712.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox