From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8742 invoked by alias); 8 Aug 2011 00:30:32 -0000 Received: (qmail 8726 invoked by uid 22791); 8 Aug 2011 00:30:30 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Aug 2011 00:30:17 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id B7C346420D; Mon, 8 Aug 2011 00:30:16 +0000 (UTC) From: Mike Frysinger To: Yao Qi Subject: Re: [RFA 4/8] New port: TI C6x: Read loadmap from gdbserver Date: Mon, 08 Aug 2011 00:30:00 -0000 User-Agent: KMail/1.13.7 (Linux/2.6.39; KDE/4.6.3; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <4E263865.2070100@codesourcery.com> <4E2CF0C6.2060504@codesourcery.com> In-Reply-To: <4E2CF0C6.2060504@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart13403280.kjRyJEocE4"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201108072030.02712.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00133.txt.bz2 --nextPart13403280.kjRyJEocE4 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 674 On Monday, July 25, 2011 00:27:50 Yao Qi wrote: > On 07/22/2011 10:16 AM, Mike Frysinger wrote: > >> +#if defined __DSBT__ > >> +static int > >=20 > > rather than being tied to the exec format that *gdbserver* is being > > built as, shouldnt this be bound to the ptrace defines being available > > ? how abut using "#ifdef PTRACE_GETDSBT" ? >=20 > Yeah, that makes sense. Done. i think you missed a spot. one place uses __DSBT__ while another uses=20 PTRACE_GETDSBT. > + addr=3D (int) PTRACE_GETDSBT_EXEC; > + else if (strcmp (annex, "interp") =3D=3D 0) > + addr =3D(int) PTRACE_GETDSBT_INTERP; there needs to be one space before and after the "=3D" here -mike --nextPart13403280.kjRyJEocE4 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJOPy4KAAoJEEFjO5/oN/WB5iQQAIr7tehJAPXShfN9Bq4d5j+x TLy/bRpl5/q9vT3O2qSbq4pikzXPVrGXgkvCRclzBCG+hKieGxeXz9z7SKsXbMXy CarKMjEvApMa2myeyGo07M8CNJJiit83B44+lS/xNXwsDQhVCjaSEHH5SPlhszpW Nuj0vfdGpgLqg/5HxevRN+Y6yK4drx6xudx2ZNUqTsHO29CwtgKgLgX96E38G2no ba8OR3tRsKRAtvphIoSxbfvryeQwKLSUaMFHiO1V2QaIPcXfdPV+SUdrEk71+1Td xi7ccKIEoDN/bnXyJOtBd0v8JXhwHAfYecEqlAiqW31PUSZiDBeymwxdUqt0wEo3 Q353l9V7YefIujDF04YHRe5IhURFi4Cub9zkJPfeMAsrtmDdm9N1zNVuNBwOVs3y udRUSGesrh/SR974ADKQMWF86/74CEo+o5y7e8O58SsbajQ4Rhzkf12YUFAcGFmz KZYZ3nkdI8g27upUrsLpPVpjcfM08U82ySwc/yXL8gN0fDMeGs8v4UVHpIsnXevj DXSPgTSDnX+XlWh08AF+x9VarC3k1wR3y46Jgo9ac0NxmrqxsYpBjYDTS4ID+WG1 BcaciLYryPeiQJlWi2zk5B6a48vHVRjEmL+PRMHL1fqpfbDMYvJWOw3yF3+ugt9a aoXZVb982kA44z7fmj2d =kqxA -----END PGP SIGNATURE----- --nextPart13403280.kjRyJEocE4--