From: Yao Qi <yao@codesourcery.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] jit-reader.h: describe interface implemented by the JIT readers.
Date: Tue, 05 Jul 2011 16:15:00 -0000 [thread overview]
Message-ID: <4E132EEB.5050800@codesourcery.com> (raw)
In-Reply-To: <1309847489-13760-1-git-send-email-sanjoy@playingwithpointers.com>
On 07/05/2011 02:31 PM, Sanjoy Das wrote:
> diff --git a/gdb/jit-reader.h b/gdb/jit-reader.h
> new file mode 100644
> index 0000000..d143714
> --- /dev/null
> +++ b/gdb/jit-reader.h
> @@ -0,0 +1,185 @@
> +/* Interface for JIT debug-info readers.
> +
> + Copyright (C) 2003, 2005, 2007, 2008, 2009, 2010, 2011
Your file is a new one added in 2011, so only need 2011 in copyright header.
> +
> +struct gdbjit_line_mapping
> +{
> + int line;
> + void *pc;
If `pc' is an address, we should use CORE_ADDR here.
> +};
> +
> +struct gdbjit_symtab_callbacks {
Please move "{" to the next line.
> +
> +/* Unique frame identifier. This should remain constant throughout the lifetime
> + of the frame concerned. */
> +struct gdbjit_frame_id
> +{
> + void *code_address;
> + void *stack_address;
> +};
Again, we should use CORE_ADDR instead of `void *'.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-07-05 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 6:27 Sanjoy Das
2011-07-05 6:27 ` [PATCH 2/4] Add symbol-handling callbacks to the jit-reader interface Sanjoy Das
2011-07-05 6:27 ` [PATCH 4/4] Activate JIT code unwinder for i386 Sanjoy Das
2011-07-05 15:34 ` Mark Kettenis
2011-07-06 2:38 ` Sanjoy Das
2011-07-06 2:46 ` Mark Kettenis
2011-07-05 7:53 ` [PATCH 3/4] Add an unwinder for JIT compiled code Sanjoy Das
2011-07-05 16:15 ` Yao Qi [this message]
2011-07-13 20:24 [PATCH 1/4] jit-reader.h: describe interface implemented by the JIT readers Sanjoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E132EEB.5050800@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=sanjoy@playingwithpointers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox