From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25701 invoked by alias); 5 Jul 2011 15:34:21 -0000 Received: (qmail 25540 invoked by uid 22791); 5 Jul 2011 15:34:20 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jul 2011 15:34:07 +0000 Received: (qmail 25484 invoked from network); 5 Jul 2011 15:34:06 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Jul 2011 15:34:06 -0000 Message-ID: <4E132EEB.5050800@codesourcery.com> Date: Tue, 05 Jul 2011 16:15:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Sanjoy Das CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] jit-reader.h: describe interface implemented by the JIT readers. References: <1309847489-13760-1-git-send-email-sanjoy@playingwithpointers.com> In-Reply-To: <1309847489-13760-1-git-send-email-sanjoy@playingwithpointers.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00153.txt.bz2 On 07/05/2011 02:31 PM, Sanjoy Das wrote: > diff --git a/gdb/jit-reader.h b/gdb/jit-reader.h > new file mode 100644 > index 0000000..d143714 > --- /dev/null > +++ b/gdb/jit-reader.h > @@ -0,0 +1,185 @@ > +/* Interface for JIT debug-info readers. > + > + Copyright (C) 2003, 2005, 2007, 2008, 2009, 2010, 2011 Your file is a new one added in 2011, so only need 2011 in copyright header. > + > +struct gdbjit_line_mapping > +{ > + int line; > + void *pc; If `pc' is an address, we should use CORE_ADDR here. > +}; > + > +struct gdbjit_symtab_callbacks { Please move "{" to the next line. > + > +/* Unique frame identifier. This should remain constant throughout the lifetime > + of the frame concerned. */ > +struct gdbjit_frame_id > +{ > + void *code_address; > + void *stack_address; > +}; Again, we should use CORE_ADDR instead of `void *'. -- Yao (齐尧)