Re: [PATCH 1/4] jit-reader.h: describe interface implemented by the JIT readers.

Yao Qi
2011-07-05T15:34:21Z

On 07/05/2011 02:31 PM, Sanjoy Das wrote:
> diff --git a/gdb/jit-reader.h b/gdb/jit-reader.h
> new file mode 100644
> index 0000000..d143714
> --- /dev/null
> +++ b/gdb/jit-reader.h
> @@ -0,0 +1,185 @@
> +/* Interface for JIT debug-info readers.
> +
> + Copyright (C) 2003, 2005, 2007, 2008, 2009, 2010, 2011

Your file is a new one added in 2011, so only need 2011 in copyright header.

> +
> +struct gdbjit_line_mapping
> +{
> + int line;
> + void *pc;

If `pc' is an address, we should use CORE_ADDR here.

> +};

> +
> +struct gdbjit_symtab_callbacks {

Please move "{" to the next line.

> +
> +/* Unique frame identifier. This should remain constant throughout the lifetime
> + of the frame concerned. */
> +struct gdbjit_frame_id
> +{
> + void *code_address;
> + void *stack_address;
> +};

Again, we should use CORE_ADDR instead of `void *'.

--
Yao (é½å°§)