Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Andrew Burgess" <aburgess@broadcom.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Display var_zinteger as signed
Date: Mon, 04 Jul 2011 11:58:00 -0000	[thread overview]
Message-ID: <4E11A672.5020808@broadcom.com> (raw)
In-Reply-To: <m3fwmmmgmp.fsf@hase.home>

On 04/07/2011 12:26, Andreas Schwab wrote:
> "Andrew Burgess"<aburgess@broadcom.com>  writes:
>
>> < something with a really silly mistake in >
>
> The "unlimited" case should not fall through.

Ooops. Thanks for pointing that out. Updated patch below.

Thanks,
Andrew


2011-07-04  Andrew Burgess  <aburgess@broadcom.com>

	* cli/cli-setshow.c (do_setshow_command): Display var_zinteger
	variables as signed, not unsigned.

diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c
index 6acdd91..868fff1 100644
--- a/gdb/cli/cli-setshow.c
+++ b/gdb/cli/cli-setshow.c
@@ -365,16 +365,17 @@ do_setshow_command (char *arg, int from_tty, 
struct cmd_list_element *c)
  	    }
  	  /* else fall through */
  	case var_zuinteger:
-	case var_zinteger:
  	  fprintf_filtered (stb->stream, "%u", *(unsigned int *) c->var);
  	  break;
  	case var_integer:
  	  if (*(int *) c->var == INT_MAX)
  	    {
  	      fputs_filtered ("unlimited", stb->stream);
+              break;
  	    }
-	  else
-	    fprintf_filtered (stb->stream, "%d", *(int *) c->var);
+	  /* else fall through */
+	case var_zinteger:
+	  fprintf_filtered (stb->stream, "%d", *(int *) c->var);
  	  break;

  	default:


  reply	other threads:[~2011-07-04 11:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 10:37 Andrew Burgess
2011-07-04 11:40 ` Andreas Schwab
2011-07-04 11:58   ` Andrew Burgess [this message]
2011-07-04 18:12     ` Joel Brobecker
2011-07-04 20:51       ` Mark Kettenis
2011-07-05  8:37       ` Andrew Burgess
2011-07-05  8:53         ` Andreas Schwab
2011-07-05 13:33           ` Andrew Burgess
2011-07-05 15:14             ` Joel Brobecker
2011-07-07  9:19               ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E11A672.5020808@broadcom.com \
    --to=aburgess@broadcom.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox