Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: aburgess@broadcom.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Display var_zinteger as signed
Date: Mon, 04 Jul 2011 20:51:00 -0000	[thread overview]
Message-ID: <201107042033.p64KXiWo022875@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20110704180902.GO2407@adacore.com> (message from Joel Brobecker	on Mon, 4 Jul 2011 11:09:02 -0700)

> Date: Mon, 4 Jul 2011 11:09:02 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > 2011-07-04  Andrew Burgess  <aburgess@broadcom.com>
> > 
> > 	* cli/cli-setshow.c (do_setshow_command): Display var_zinteger
> > 	variables as signed, not unsigned.
> 
> I'm not a fan of fall throughs, like this, because I think it
> makes the code harder to read, but if no other maintainer has
> an objection to it, then the patch is OK (please wait for a couple
> of days to give everyone else a little time to comment on this).

And if the fallthrough stays, the proper spelling is /* FALLTHROUGH
*/.  There are several code analysis tools that understand that
comment as signalling an intentional fallthrough instead of an
unintentional one that they need to warn about.


  reply	other threads:[~2011-07-04 20:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 10:37 Andrew Burgess
2011-07-04 11:40 ` Andreas Schwab
2011-07-04 11:58   ` Andrew Burgess
2011-07-04 18:12     ` Joel Brobecker
2011-07-04 20:51       ` Mark Kettenis [this message]
2011-07-05  8:37       ` Andrew Burgess
2011-07-05  8:53         ` Andreas Schwab
2011-07-05 13:33           ` Andrew Burgess
2011-07-05 15:14             ` Joel Brobecker
2011-07-07  9:19               ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107042033.p64KXiWo022875@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=aburgess@broadcom.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox