From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82031-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7589 invoked by alias); 4 Jul 2011 20:34:19 -0000
Received: (qmail 7467 invoked by uid 22791); 4 Jul 2011 20:34:19 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jul 2011 20:34:05 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p64KXj2f021976;	Mon, 4 Jul 2011 22:33:45 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p64KXiWo022875;	Mon, 4 Jul 2011 22:33:44 +0200 (CEST)
Date: Mon, 04 Jul 2011 20:51:00 -0000
Message-Id: <201107042033.p64KXiWo022875@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
CC: aburgess@broadcom.com, gdb-patches@sourceware.org
In-reply-to: <20110704180902.GO2407@adacore.com> (message from Joel Brobecker	on Mon, 4 Jul 2011 11:09:02 -0700)
Subject: Re: [PATCH] Display var_zinteger as signed
References: <4E11976B.9030100@broadcom.com> <m3fwmmmgmp.fsf@hase.home> <4E11A672.5020808@broadcom.com> <20110704180902.GO2407@adacore.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00126.txt.bz2

> Date: Mon, 4 Jul 2011 11:09:02 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > 2011-07-04  Andrew Burgess  <aburgess@broadcom.com>
> > 
> > 	* cli/cli-setshow.c (do_setshow_command): Display var_zinteger
> > 	variables as signed, not unsigned.
> 
> I'm not a fan of fall throughs, like this, because I think it
> makes the code harder to read, but if no other maintainer has
> an objection to it, then the patch is OK (please wait for a couple
> of days to give everyone else a little time to comment on this).

And if the fallthrough stays, the proper spelling is /* FALLTHROUGH
*/.  There are several code analysis tools that understand that
comment as signalling an intentional fallthrough instead of an
unintentional one that they need to warn about.