From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22595 invoked by alias); 4 Jul 2011 11:40:11 -0000 Received: (qmail 22518 invoked by uid 22791); 4 Jul 2011 11:40:10 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jul 2011 11:39:49 +0000 Received: from [10.9.200.133] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Mon, 04 Jul 2011 04:44:12 -0700 X-Server-Uuid: D3C04415-6FA8-4F2C-93C1-920E106A2031 Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB02.corp.ad.broadcom.com (10.9.200.133) with Microsoft SMTP Server id 8.2.247.2; Mon, 4 Jul 2011 04:39:19 -0700 Received: from [10.177.73.61] (unknown [10.177.73.61]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 7DA4574D03 for ; Mon, 4 Jul 2011 04:39:31 -0700 (PDT) Message-ID: <4E11A672.5020808@broadcom.com> Date: Mon, 04 Jul 2011 11:58:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.18) Gecko/20110616 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Display var_zinteger as signed References: <4E11976B.9030100@broadcom.com> In-Reply-To: Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00092.txt.bz2 On 04/07/2011 12:26, Andreas Schwab wrote: > "Andrew Burgess" writes: > >> < something with a really silly mistake in > > > The "unlimited" case should not fall through. Ooops. Thanks for pointing that out. Updated patch below. Thanks, Andrew 2011-07-04 Andrew Burgess * cli/cli-setshow.c (do_setshow_command): Display var_zinteger variables as signed, not unsigned. diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c index 6acdd91..868fff1 100644 --- a/gdb/cli/cli-setshow.c +++ b/gdb/cli/cli-setshow.c @@ -365,16 +365,17 @@ do_setshow_command (char *arg, int from_tty, struct cmd_list_element *c) } /* else fall through */ case var_zuinteger: - case var_zinteger: fprintf_filtered (stb->stream, "%u", *(unsigned int *) c->var); break; case var_integer: if (*(int *) c->var == INT_MAX) { fputs_filtered ("unlimited", stb->stream); + break; } - else - fprintf_filtered (stb->stream, "%d", *(int *) c->var); + /* else fall through */ + case var_zinteger: + fprintf_filtered (stb->stream, "%d", *(int *) c->var); break; default: