Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch, testsuite] Don't "set debug lin-lwp 1" in ia64-sigill.exp
@ 2011-06-14  7:30 Yao Qi
  2011-06-14  7:40 ` Jan Kratochvil
  0 siblings, 1 reply; 3+ messages in thread
From: Yao Qi @ 2011-06-14  7:30 UTC (permalink / raw)
  To: gdb-patches; +Cc: Jan Kratochvil

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

command "lin-lwp" is defined in linux-nat.c, so for GDB without
linux-nat.o, command "set debug lin-lwp 1" can't be found, like this:

set debug lin-lwp 1^M
Undefined set debug command: "lin-lwp 1".  Try "help set debug".^M
(gdb) FAIL: gdb.threads/ia64-sigill.exp: set debug lin-lwp 1

I examine the test code, and comment says "The ia64 SIGILL signal is
visible only in the lin-lwp debug.", however, I don't see any code
checks the lin-lwp debug output.  I think this line of code "set debug
lin-lwp 1" can be removed from this test case.

OK?

-- 
Yao (齐尧)

[-- Attachment #2: remove_debug_lin-lwp.patch --]
[-- Type: text/x-patch, Size: 685 bytes --]

2011-06-14  Yao Qi  <yao@codesourcery.com>

	gdb/testsuite/
	* gdb.threads/ia64-sigill.exp: Remove "set debug lin-lwp 1".

diff --git a/gdb/testsuite/gdb.threads/ia64-sigill.exp b/gdb/testsuite/gdb.threads/ia64-sigill.exp
index 2b0290f..93f753c 100644
--- a/gdb/testsuite/gdb.threads/ia64-sigill.exp
+++ b/gdb/testsuite/gdb.threads/ia64-sigill.exp
@@ -57,9 +57,6 @@ gdb_breakpoint [gdb_get_line_number "break-at-exit"]
 
 gdb_test_no_output "set debug infrun 1"
 
-# The ia64 SIGILL signal is visible only in the lin-lwp debug.
-gdb_test_no_output "set debug lin-lwp 1"
-
 gdb_test "continue" "Breakpoint \[0-9\]+,( .* in)? thread_func .*"
 
 gdb_test_no_output {delete $sigill_bpnum}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch, testsuite] Don't "set debug lin-lwp 1" in ia64-sigill.exp
  2011-06-14  7:30 [patch, testsuite] Don't "set debug lin-lwp 1" in ia64-sigill.exp Yao Qi
@ 2011-06-14  7:40 ` Jan Kratochvil
  2011-06-14  8:07   ` [committed] " Yao Qi
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Kratochvil @ 2011-06-14  7:40 UTC (permalink / raw)
  To: Yao Qi; +Cc: gdb-patches

On Tue, 14 Jun 2011 09:30:18 +0200, Yao Qi wrote:
> I examine the test code, and comment says "The ia64 SIGILL signal is
> visible only in the lin-lwp debug.", however, I don't see any code
> checks the lin-lwp debug output.  I think this line of code "set debug
> lin-lwp 1" can be removed from this test case.

OK, I would keep that comment about lin-lwp still there.


Thanks,
Jan


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [committed] [patch, testsuite] Don't "set debug lin-lwp 1" in ia64-sigill.exp
  2011-06-14  7:40 ` Jan Kratochvil
@ 2011-06-14  8:07   ` Yao Qi
  0 siblings, 0 replies; 3+ messages in thread
From: Yao Qi @ 2011-06-14  8:07 UTC (permalink / raw)
  To: Jan Kratochvil; +Cc: gdb-patches

On 06/14/2011 03:40 PM, Jan Kratochvil wrote:
> OK, I would keep that comment about lin-lwp still there.

OK, keep comment there.  Committed this one-line patch.  Thanks for the
quick review.

http://sourceware.org/ml/gdb-cvs/2011-06/msg00069.html

-- 
Yao (齐尧)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-06-14  8:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-14  7:30 [patch, testsuite] Don't "set debug lin-lwp 1" in ia64-sigill.exp Yao Qi
2011-06-14  7:40 ` Jan Kratochvil
2011-06-14  8:07   ` [committed] " Yao Qi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox