Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [patch, testsuite] Don't "set debug lin-lwp 1" in ia64-sigill.exp
Date: Tue, 14 Jun 2011 07:30:00 -0000	[thread overview]
Message-ID: <4DF70E0A.1020606@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

command "lin-lwp" is defined in linux-nat.c, so for GDB without
linux-nat.o, command "set debug lin-lwp 1" can't be found, like this:

set debug lin-lwp 1^M
Undefined set debug command: "lin-lwp 1".  Try "help set debug".^M
(gdb) FAIL: gdb.threads/ia64-sigill.exp: set debug lin-lwp 1

I examine the test code, and comment says "The ia64 SIGILL signal is
visible only in the lin-lwp debug.", however, I don't see any code
checks the lin-lwp debug output.  I think this line of code "set debug
lin-lwp 1" can be removed from this test case.

OK?

-- 
Yao (齐尧)

[-- Attachment #2: remove_debug_lin-lwp.patch --]
[-- Type: text/x-patch, Size: 685 bytes --]

2011-06-14  Yao Qi  <yao@codesourcery.com>

	gdb/testsuite/
	* gdb.threads/ia64-sigill.exp: Remove "set debug lin-lwp 1".

diff --git a/gdb/testsuite/gdb.threads/ia64-sigill.exp b/gdb/testsuite/gdb.threads/ia64-sigill.exp
index 2b0290f..93f753c 100644
--- a/gdb/testsuite/gdb.threads/ia64-sigill.exp
+++ b/gdb/testsuite/gdb.threads/ia64-sigill.exp
@@ -57,9 +57,6 @@ gdb_breakpoint [gdb_get_line_number "break-at-exit"]
 
 gdb_test_no_output "set debug infrun 1"
 
-# The ia64 SIGILL signal is visible only in the lin-lwp debug.
-gdb_test_no_output "set debug lin-lwp 1"
-
 gdb_test "continue" "Breakpoint \[0-9\]+,( .* in)? thread_func .*"
 
 gdb_test_no_output {delete $sigill_bpnum}

             reply	other threads:[~2011-06-14  7:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14  7:30 Yao Qi [this message]
2011-06-14  7:40 ` Jan Kratochvil
2011-06-14  8:07   ` [committed] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF70E0A.1020606@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox