Re: ping: Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver)

[Yao Qi <yao@codesourcery.com>]

On 05/22/2011 06:20 AM, Philippe Waroquiers wrote:

I am not the people to approve or reject this patch.

>  
>  *** Changes since GDB 7.3
>  
> + * GDB has two new commands: "set remote hardware-watchpoint-length-limit"
> +   and "show remote hardware-watchpoint-length-limit".  These allows to
> +   set or show the maximum length limit (in bytes) of a remote
> +   target hardware watchpoint.
> + +   This allows e.g. to use "unlimited" hardware watchpoints with the
    ^ Looks there is a surplus '+'.

> +   gdbserver integrated in Valgrind version >= 3.7.0.  Such Valgrind
> +   watchpoints are slower than real hardware watchpoints but are
> +   significantly faster than gdb software watchpoints.

If I understand you correctly, this commands are only useful in
gdbserver+valgrind.  If gdb is running in normal remote target, using
`set remote hardware-watchpoint-length-limit' will make GDB work
incorrectly.

Maybe, we need a new target `remote-valgrind' here, and move your stuff
there.

> +  * libthread-db-search-path now supports two special values: $sdir and
> $pdir.

This line of change above is not about your patch.

> + + static int
    ^ a surplus '+'.


> Index: gdb/doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
> retrieving revision 1.838
> diff -c -p -r1.838 gdb.texinfo
> *** gdb/doc/gdb.texinfo    13 May 2011 22:36:07 -0000    1.838
> --- gdb/doc/gdb.texinfo    21 May 2011 19:49:12 -0000
> *************** responses.
> *** 16578,16583 ****
> --- 16578,16595 ----
>  Restrict @value{GDBN} to using @var{limit} remote hardware breakpoint or
>  watchpoints.  A limit of -1, the default, is treated as unlimited.
>  
> + @cindex limit hardware watchpoints length
> + @cindex remote target, limit watchpoints length
> + @anchor{set remote hardware-watchpoint-length-limit}
> + @item set remote hardware-watchpoint-length-limit @var{limit}
> + Restrict @value{GDBN} to using @var{limit} bytes for the maximum
> length of
> + a remote hardware watchpoint.  A limit of -1, the default, is treated
> + as unlimited.
> + + @item show remote hardware-watchpoint-length-limit
    ^ a surplus '+'.

-- 
Yao (齐尧)