From: Marek Polacek <mpolacek@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.base/setshow.exp: fix racy tests (PR testsuite/12649)
Date: Tue, 19 Apr 2011 13:21:00 -0000 [thread overview]
Message-ID: <4DAD8C40.30703@redhat.com> (raw)
In-Reply-To: <m3oc425ros.fsf@fleche.redhat.com>
On 04/19/2011 02:52 PM, Tom Tromey wrote:
> Maybe gdb.log says something, or maybe running with --verbose would
> help.
The `runtest -v -v -v gdb.base/setshow.exp' says this:
Looking to match ""[\r\n]*(Input and output radices now set to decimal 16, hex
10, octal 20..*)[\r\n]+\(gdb\) $"; "(^FOOBAR$)$""
Note those '\' around (gdb). This is probably the reason why we need to supply
"\\".
> Also, looking at the code, it seems to me that the section that sets the
> prompt to "(FooBarBaz) " should also set and restore gdb_prompt. That
> is because gdb_test_multiple references this. What do you think?
The prompt is restored by the gdb_test_multiple "set prompt \\(gdb\\) ".
Then it is checked by the -re "$gdb_prompt $". I think this is correct.
Marek
next prev parent reply other threads:[~2011-04-19 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 16:39 Marek Polacek
2011-04-18 20:46 ` Tom Tromey
2011-04-19 7:01 ` Marek Polacek
2011-04-19 10:19 ` Andreas Schwab
2011-04-19 10:31 ` Marek Polacek
2011-04-19 12:52 ` Tom Tromey
2011-04-19 13:21 ` Marek Polacek [this message]
2011-04-19 13:48 ` Andreas Schwab
2011-04-19 18:47 ` Tom Tromey
2011-04-19 19:11 ` Marek Polacek
2011-04-19 20:28 ` Andreas Schwab
2011-04-20 11:25 ` Marek Polacek
2011-04-20 13:54 ` Tom Tromey
2011-04-20 14:58 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAD8C40.30703@redhat.com \
--to=mpolacek@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox