From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21391 invoked by alias); 19 Apr 2011 13:21:26 -0000 Received: (qmail 21382 invoked by uid 22791); 19 Apr 2011 13:21:25 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 13:21:06 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3JDL5LJ029346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Apr 2011 09:21:06 -0400 Received: from dhcp-25-89.brq.redhat.com (pdp-11.brq.redhat.com [10.34.24.63]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3JDL434029912; Tue, 19 Apr 2011 09:21:05 -0400 Message-ID: <4DAD8C40.30703@redhat.com> Date: Tue, 19 Apr 2011 13:21:00 -0000 From: Marek Polacek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.base/setshow.exp: fix racy tests (PR testsuite/12649) References: <4DAC6924.2000100@redhat.com> <4DAD333D.6010103@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00318.txt.bz2 On 04/19/2011 02:52 PM, Tom Tromey wrote: > Maybe gdb.log says something, or maybe running with --verbose would > help. The `runtest -v -v -v gdb.base/setshow.exp' says this: Looking to match ""[\r\n]*(Input and output radices now set to decimal 16, hex 10, octal 20..*)[\r\n]+\(gdb\) $"; "(^FOOBAR$)$"" Note those '\' around (gdb). This is probably the reason why we need to supply "\\". > Also, looking at the code, it seems to me that the section that sets the > prompt to "(FooBarBaz) " should also set and restore gdb_prompt. That > is because gdb_test_multiple references this. What do you think? The prompt is restored by the gdb_test_multiple "set prompt \\(gdb\\) ". Then it is checked by the -re "$gdb_prompt $". I think this is correct. Marek