From: Tom Tromey <tromey@redhat.com>
To: Marek Polacek <mpolacek@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.base/setshow.exp: fix racy tests (PR testsuite/12649)
Date: Mon, 18 Apr 2011 20:46:00 -0000 [thread overview]
Message-ID: <m31v0z70g2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4DAC6924.2000100@redhat.com> (Marek Polacek's message of "Mon, 18 Apr 2011 18:39:00 +0200")
>>>>> "Marek" == Marek Polacek <mpolacek@redhat.com> writes:
Marek> It took some time, but I've fixed all racy cases by using
Marek> {,old_}gdb_prompt variable. Also it was needed to escape "(gdb)
Marek> " prompt properly. Ok to apply?
This seems ok, but...
Marek> - gdb_test_multiple "set prompt (gdb) " "set prompt gdb" {
Marek> + gdb_test_multiple "set prompt \\(gdb\\) " "set prompt gdb" {
I think this should not be needed.
Tom
next prev parent reply other threads:[~2011-04-18 20:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 16:39 Marek Polacek
2011-04-18 20:46 ` Tom Tromey [this message]
2011-04-19 7:01 ` Marek Polacek
2011-04-19 10:19 ` Andreas Schwab
2011-04-19 10:31 ` Marek Polacek
2011-04-19 12:52 ` Tom Tromey
2011-04-19 13:21 ` Marek Polacek
2011-04-19 13:48 ` Andreas Schwab
2011-04-19 18:47 ` Tom Tromey
2011-04-19 19:11 ` Marek Polacek
2011-04-19 20:28 ` Andreas Schwab
2011-04-20 11:25 ` Marek Polacek
2011-04-20 13:54 ` Tom Tromey
2011-04-20 14:58 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31v0z70g2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mpolacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox