Re: [RFA] frame.c (find_frame_sal): Check return value of get_frame_function.

[Michael Snyder <msnyder@vmware.com>]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

Pedro Alves wrote:
> On Tuesday 15 March 2011 17:38:05, Joel Brobecker wrote:
>>> It would normally, but in this case, we've just found that
>>> the next frame is an inlined function call.  Then it
>>> certainly has debug info?  Otherwise, how would gdb know
>>> it's an inlined function call?
>> Indeed, I think you're right. inline_skipped_symbol shouldn't
>> be returning a NULL symbol, as far as I can tell.  So should
>> we just add a gdb_assert with a comment explaining why we
>> expect sym to be non-NULL?
> 
> I think so.
> 

How's this?



[-- Attachment #2: null17b.txt --]
[-- Type: text/plain, Size: 631 bytes --]

2011-03-15  Michael Snyder  <msnyder@vmware.com>

	* frame.c (find_frame_sal): Assert sym is not null.

Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.292
diff -u -p -r1.292 frame.c
--- frame.c	9 Mar 2011 14:22:09 -0000	1.292
+++ frame.c	15 Mar 2011 19:11:48 -0000
@@ -1899,6 +1899,8 @@ find_frame_sal (struct frame_info *frame
       else
 	sym = inline_skipped_symbol (inferior_ptid);
 
+      /* If frame is inline, it certainly has symbols.  */
+      gdb_assert (sym);
       init_sal (sal);
       if (SYMBOL_LINE (sym) != 0)
 	{