From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
Michael Snyder <msnyder@vmware.com>
Subject: Re: [RFA] frame.c (find_frame_sal): Check return value of get_frame_function.
Date: Tue, 15 Mar 2011 17:43:00 -0000 [thread overview]
Message-ID: <201103151653.54091.pedro@codesourcery.com> (raw)
In-Reply-To: <20110315162609.GM31264@adacore.com>
On Tuesday 15 March 2011 16:26:09, Joel Brobecker wrote:
> > 2011-03-04 Michael Snyder <msnyder@vmware.com>
> >
> > * frame.c (find_frame_sal): Check return value of get_frame_function.
>
> I think that the change is correct, but I'm not completely sure,
> so a second pair of eyes would be nice.
>
> My thinking: It is entirely plausible that get_next_frame (frame)
> returns a frame with a PC for which there is no debugging info.
> In that case, it's the same as not having line info.
It would normally, but in this case, we've just found that
the next frame is an inlined function call. Then it
certainly has debug info? Otherwise, how would gdb know
it's an inlined function call?
--
Pedro Alves
next prev parent reply other threads:[~2011-03-15 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 1:31 Michael Snyder
2011-03-11 22:50 ` Michael Snyder
2011-03-15 16:49 ` Joel Brobecker
2011-03-15 17:43 ` Pedro Alves [this message]
2011-03-15 17:44 ` Joel Brobecker
2011-03-15 17:54 ` Pedro Alves
2011-03-15 19:26 ` Michael Snyder
2011-03-15 19:29 ` Pedro Alves
2011-03-15 20:01 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103151653.54091.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox