From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20954 invoked by alias); 15 Mar 2011 16:54:08 -0000 Received: (qmail 20940 invoked by uid 22791); 15 Mar 2011 16:54:07 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 16:54:01 +0000 Received: (qmail 8028 invoked from network); 15 Mar 2011 16:53:59 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Mar 2011 16:53:59 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] frame.c (find_frame_sal): Check return value of get_frame_function. Date: Tue, 15 Mar 2011 17:43:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: Joel Brobecker , Michael Snyder References: <4D719288.6050301@vmware.com> <20110315162609.GM31264@adacore.com> In-Reply-To: <20110315162609.GM31264@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103151653.54091.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00797.txt.bz2 On Tuesday 15 March 2011 16:26:09, Joel Brobecker wrote: > > 2011-03-04 Michael Snyder > > > > * frame.c (find_frame_sal): Check return value of get_frame_function. > > I think that the change is correct, but I'm not completely sure, > so a second pair of eyes would be nice. > > My thinking: It is entirely plausible that get_next_frame (frame) > returns a frame with a PC for which there is no debugging info. > In that case, it's the same as not having line info. It would normally, but in this case, we've just found that the next frame is an inlined function call. Then it certainly has debug info? Otherwise, how would gdb know it's an inlined function call? -- Pedro Alves