From: Yao Qi <yao@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [revert patch] Remove configure/make in common/
Date: Wed, 09 Mar 2011 11:15:00 -0000 [thread overview]
Message-ID: <4D771DE2.5020307@codesourcery.com> (raw)
In-Reply-To: <20110309041816.GS30306@adacore.com>
On 03/09/2011 12:18 PM, Joel Brobecker wrote:
> This looks good to me. I also did some testing on my own, verifying
> the few issues I noticed (Eg. "make configure-gdb; make clean",
> very that autoconf, autoheader et al do not get called, etc).
> So, let's go ahead and commit.
>
>> > @@ -337,6 +331,7 @@ SUBDIR_PYTHON_DEPS =
>> > SUBDIR_PYTHON_LDFLAGS=
>> > SUBDIR_PYTHON_CFLAGS=
>> >
>> > +
>> > # Opcodes currently live in one of two places. Either they are in the
> This part does not need reverting, though (this is a good example of
> why it's better to avoid mixing formatting changes with real changes,
> when they are independent).
Thanks for the review. Remove this chunk. Applied.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-03-09 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 10:56 Yao Qi
2011-03-09 5:00 ` Joel Brobecker
2011-03-09 11:15 ` Yao Qi [this message]
2011-03-11 11:47 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D771DE2.5020307@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox