From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29655 invoked by alias); 9 Mar 2011 06:27:56 -0000 Received: (qmail 29647 invoked by uid 22791); 9 Mar 2011 06:27:55 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 06:27:50 +0000 Received: (qmail 7489 invoked from network); 9 Mar 2011 06:27:48 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Mar 2011 06:27:48 -0000 Message-ID: <4D771DE2.5020307@codesourcery.com> Date: Wed, 09 Mar 2011 11:15:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [revert patch] Remove configure/make in common/ References: <4D75FC71.7050301@codesourcery.com> <20110309041816.GS30306@adacore.com> In-Reply-To: <20110309041816.GS30306@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00587.txt.bz2 On 03/09/2011 12:18 PM, Joel Brobecker wrote: > This looks good to me. I also did some testing on my own, verifying > the few issues I noticed (Eg. "make configure-gdb; make clean", > very that autoconf, autoheader et al do not get called, etc). > So, let's go ahead and commit. > >> > @@ -337,6 +331,7 @@ SUBDIR_PYTHON_DEPS = >> > SUBDIR_PYTHON_LDFLAGS= >> > SUBDIR_PYTHON_CFLAGS= >> > >> > + >> > # Opcodes currently live in one of two places. Either they are in the > This part does not need reverting, though (this is a good example of > why it's better to avoid mixing formatting changes with real changes, > when they are independent). Thanks for the review. Remove this chunk. Applied. -- Yao (齐尧)