From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [revert patch] Remove configure/make in common/
Date: Wed, 09 Mar 2011 05:00:00 -0000 [thread overview]
Message-ID: <20110309041816.GS30306@adacore.com> (raw)
In-Reply-To: <4D75FC71.7050301@codesourcery.com>
> gdb/
> 2011-03-08 Yao Qi <yao@codesourcery.com>
>
> Revert:
> 2011-02-11 Yao Qi <yao@codesourcery.com>
>
> * common/Makefile.in: Add copyright header.
>
> 2011-02-11 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in: Remove signals.o from COMMON_OBS. Link
> libcommon.a.
> * configure.ac: Add common to sub dir.
> * configure: Regenerate
>
> gdb/gdbserver/
> 2011-03-08 Yao Qi <yao@codesourcery.com>
>
> Revert:
> 2011-03-04 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in: Remove GNU make feature --directory.
>
> 2011-03-05 Yao Qi <yao@codesourcery.com>
>
> * Makefile.in (CLEANDIRS, REQUIRED_SUBDIRS): New variable.
> (subdir_do): New make target. Copied from gdb/Makefile.
> (maintainer-clean, realclean, distclean, clean): Call corresponding
> make targets in common/Makefile.
>
> 2011-02-11 Yao Qi <yao@codesourcery.com>
>
> * configure.ac: Call AC_PROG_RANLIB.
> * Makefile.in: Remove signals.o from OBS. Link libcommon.a.
> * configure: Regenerate.
This looks good to me. I also did some testing on my own, verifying
the few issues I noticed (Eg. "make configure-gdb; make clean",
very that autoconf, autoheader et al do not get called, etc).
So, let's go ahead and commit.
> @@ -337,6 +331,7 @@ SUBDIR_PYTHON_DEPS =
> SUBDIR_PYTHON_LDFLAGS=
> SUBDIR_PYTHON_CFLAGS=
>
> +
> # Opcodes currently live in one of two places. Either they are in the
This part does not need reverting, though (this is a good example of
why it's better to avoid mixing formatting changes with real changes,
when they are independent).
Thanks a lot, Yao.
--
Joel
next prev parent reply other threads:[~2011-03-09 4:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 10:56 Yao Qi
2011-03-09 5:00 ` Joel Brobecker [this message]
2011-03-09 11:15 ` Yao Qi
2011-03-11 11:47 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309041816.GS30306@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox