From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25276 invoked by alias); 9 Mar 2011 04:18:49 -0000 Received: (qmail 25256 invoked by uid 22791); 9 Mar 2011 04:18:48 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 04:18:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0FAD02BAF8F; Tue, 8 Mar 2011 23:18:43 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Gp0d2NgfnGUw; Tue, 8 Mar 2011 23:18:43 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 94E372BAF8D; Tue, 8 Mar 2011 23:18:42 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0226D1459AD; Wed, 9 Mar 2011 08:18:16 +0400 (RET) Date: Wed, 09 Mar 2011 05:00:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [revert patch] Remove configure/make in common/ Message-ID: <20110309041816.GS30306@adacore.com> References: <4D75FC71.7050301@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D75FC71.7050301@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00583.txt.bz2 > gdb/ > 2011-03-08 Yao Qi > > Revert: > 2011-02-11 Yao Qi > > * common/Makefile.in: Add copyright header. > > 2011-02-11 Yao Qi > > * Makefile.in: Remove signals.o from COMMON_OBS. Link > libcommon.a. > * configure.ac: Add common to sub dir. > * configure: Regenerate > > gdb/gdbserver/ > 2011-03-08 Yao Qi > > Revert: > 2011-03-04 Yao Qi > > * Makefile.in: Remove GNU make feature --directory. > > 2011-03-05 Yao Qi > > * Makefile.in (CLEANDIRS, REQUIRED_SUBDIRS): New variable. > (subdir_do): New make target. Copied from gdb/Makefile. > (maintainer-clean, realclean, distclean, clean): Call corresponding > make targets in common/Makefile. > > 2011-02-11 Yao Qi > > * configure.ac: Call AC_PROG_RANLIB. > * Makefile.in: Remove signals.o from OBS. Link libcommon.a. > * configure: Regenerate. This looks good to me. I also did some testing on my own, verifying the few issues I noticed (Eg. "make configure-gdb; make clean", very that autoconf, autoheader et al do not get called, etc). So, let's go ahead and commit. > @@ -337,6 +331,7 @@ SUBDIR_PYTHON_DEPS = > SUBDIR_PYTHON_LDFLAGS= > SUBDIR_PYTHON_CFLAGS= > > + > # Opcodes currently live in one of two places. Either they are in the This part does not need reverting, though (this is a good example of why it's better to avoid mixing formatting changes with real changes, when they are independent). Thanks a lot, Yao. -- Joel