* [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?
@ 2011-03-03 19:12 Michael Snyder
2011-03-03 20:48 ` Kai Tietz
2011-03-03 22:27 ` Alan Modra
0 siblings, 2 replies; 4+ messages in thread
From: Michael Snyder @ 2011-03-03 19:12 UTC (permalink / raw)
To: nickc, bug-binutils, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 81 bytes --]
If rel-r_type is equal to ARRA_SIZE, it will overflow the array.
What say you?
[-- Attachment #2: coff-x86-64.txt --]
[-- Type: text/plain, Size: 663 bytes --]
2011-03-03 Michael Snyder <msnyder@vmware.com>
* coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
Index: coff-x86_64.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-x86_64.c,v
retrieving revision 1.12
diff -u -p -u -p -r1.12 coff-x86_64.c
--- coff-x86_64.c 31 Mar 2010 16:32:02 -0000 1.12
+++ coff-x86_64.c 3 Mar 2011 19:07:58 -0000
@@ -546,7 +546,7 @@ coff_amd64_rtype_to_howto (bfd *abfd ATT
{
reloc_howto_type *howto;
- if (rel->r_type > ARRAY_SIZE (howto_table))
+ if (rel->r_type >= ARRAY_SIZE (howto_table))
{
bfd_set_error (bfd_error_bad_value);
return NULL;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?
2011-03-03 19:12 [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error? Michael Snyder
@ 2011-03-03 20:48 ` Kai Tietz
2011-03-03 22:27 ` Alan Modra
1 sibling, 0 replies; 4+ messages in thread
From: Kai Tietz @ 2011-03-03 20:48 UTC (permalink / raw)
To: Michael Snyder; +Cc: nickc, bug-binutils, gdb-patches
2011/3/3 Michael Snyder <msnyder@vmware.com>:
> If rel-r_type is equal to ARRA_SIZE, it will overflow the array.
>
> What say you?
>
>
> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>
> * coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
I can't approve this patch, but looks ok.
Kai
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?
2011-03-03 19:12 [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error? Michael Snyder
2011-03-03 20:48 ` Kai Tietz
@ 2011-03-03 22:27 ` Alan Modra
2011-03-03 23:49 ` Michael Snyder
1 sibling, 1 reply; 4+ messages in thread
From: Alan Modra @ 2011-03-03 22:27 UTC (permalink / raw)
To: Michael Snyder; +Cc: nickc, bug-binutils, gdb-patches
On Thu, Mar 03, 2011 at 11:12:34AM -0800, Michael Snyder wrote:
> * coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
OK.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-03 23:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-03 19:12 [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error? Michael Snyder
2011-03-03 20:48 ` Kai Tietz
2011-03-03 22:27 ` Alan Modra
2011-03-03 23:49 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox