From: Michael Snyder <msnyder@vmware.com>
To: nickc@redhat.com, bug-binutils@gnu.org,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?
Date: Thu, 03 Mar 2011 19:12:00 -0000 [thread overview]
Message-ID: <4D6FE822.3080808@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 81 bytes --]
If rel-r_type is equal to ARRA_SIZE, it will overflow the array.
What say you?
[-- Attachment #2: coff-x86-64.txt --]
[-- Type: text/plain, Size: 663 bytes --]
2011-03-03 Michael Snyder <msnyder@vmware.com>
* coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
Index: coff-x86_64.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-x86_64.c,v
retrieving revision 1.12
diff -u -p -u -p -r1.12 coff-x86_64.c
--- coff-x86_64.c 31 Mar 2010 16:32:02 -0000 1.12
+++ coff-x86_64.c 3 Mar 2011 19:07:58 -0000
@@ -546,7 +546,7 @@ coff_amd64_rtype_to_howto (bfd *abfd ATT
{
reloc_howto_type *howto;
- if (rel->r_type > ARRAY_SIZE (howto_table))
+ if (rel->r_type >= ARRAY_SIZE (howto_table))
{
bfd_set_error (bfd_error_bad_value);
return NULL;
next reply other threads:[~2011-03-03 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 19:12 Michael Snyder [this message]
2011-03-03 20:48 ` Kai Tietz
2011-03-03 22:27 ` Alan Modra
2011-03-03 23:49 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6FE822.3080808@vmware.com \
--to=msnyder@vmware.com \
--cc=bug-binutils@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox