[RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?

Michael Snyder
2011-03-03T19:12:41Z

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]

If rel-r_type is equal to ARRA_SIZE, it will overflow the array.

What say you?

[-- Attachment #2: coff-x86-64.txt --]
[-- Type: text/plain, Size: 663 bytes --]

2011-03-03 Michael Snyder <msnyder@vmware.com>

* coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.

Index: coff-x86_64.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-x86_64.c,v
retrieving revision 1.12
diff -u -p -u -p -r1.12 coff-x86_64.c
--- coff-x86_64.c 31 Mar 2010 16:32:02 -0000 1.12
+++ coff-x86_64.c 3 Mar 2011 19:07:58 -0000
@@ -546,7 +546,7 @@ coff_amd64_rtype_to_howto (bfd *abfd ATT
{
reloc_howto_type *howto;

- if (rel->r_type > ARRAY_SIZE (howto_table))
+ if (rel->r_type >= ARRAY_SIZE (howto_table))
{
bfd_set_error (bfd_error_bad_value);
return NULL;