From: Michael Snyder <msnyder@vmware.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] linux-nat.c, linux_handle_extended_wait: delete unused variable
Date: Tue, 01 Mar 2011 02:33:00 -0000 [thread overview]
Message-ID: <4D6C5AE6.2000007@vmware.com> (raw)
In-Reply-To: <4D6C5533.80609@caviumnetworks.com>
David Daney wrote:
> On 02/28/2011 04:41 PM, Michael Snyder wrote:
>> checked in.
>>
>>
>>
>> 2011-02-28 Michael Snyder<msnyder@vmware.com>
>>
>> * linux-nat.c (linux_handle_extended_wait): Delete unused variable.
>
> I'm probably being pedantic, but that is not entirely accurate in this
> case. It is more like:
>
> Rewrite by nesting expressions to use fewer declared variables.
I'll change it if you really want...
>> Index: linux-nat.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/linux-nat.c,v
>> retrieving revision 1.196
>> diff -u -p -u -p -r1.196 linux-nat.c
>> --- linux-nat.c 27 Feb 2011 16:25:37 -0000 1.196
>> +++ linux-nat.c 1 Mar 2011 00:39:00 -0000
>> @@ -2198,8 +2198,6 @@ linux_handle_extended_wait (struct lwp_i
>> if (event == PTRACE_EVENT_FORK
>> && linux_fork_checkpointing_p (GET_PID (lp->ptid)))
>> {
>> - struct fork_info *fp;
>> -
>> /* Handle checkpointing by linux-fork.c here as a special
>> case. We don't want the follow-fork-mode or 'catch fork'
>> to interfere with this. */
>> @@ -2209,9 +2207,8 @@ linux_handle_extended_wait (struct lwp_i
>> detach_breakpoints (new_pid);
>>
>> /* Retain child fork in ptrace (stopped) state. */
>> - fp = find_fork_pid (new_pid);
>> - if (!fp)
>> - fp = add_fork (new_pid);
>> + if (!find_fork_pid (new_pid))
>> + add_fork (new_pid);
>>
>> /* Report as spurious, so that infrun doesn't want to follow
>> this fork. We're actually doing an infcall in
>
prev parent reply other threads:[~2011-03-01 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 0:41 Michael Snyder
2011-03-01 2:09 ` David Daney
2011-03-01 2:33 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6C5AE6.2000007@vmware.com \
--to=msnyder@vmware.com \
--cc=ddaney@caviumnetworks.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox