Re: [commit] linux-nat.c, linux_handle_extended_wait: delete unused variable

Michael Snyder
2011-03-01T02:33:22Z

David Daney wrote:
> On 02/28/2011 04:41 PM, Michael Snyder wrote:
>> checked in.
>>
>>
>>
>> 2011-02-28 Michael Snyder<msnyder@vmware.com>
>>
>> * linux-nat.c (linux_handle_extended_wait): Delete unused variable.
>
> I'm probably being pedantic, but that is not entirely accurate in this
> case. It is more like:
>
> Rewrite by nesting expressions to use fewer declared variables.

I'll change it if you really want...

>> Index: linux-nat.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/linux-nat.c,v
>> retrieving revision 1.196
>> diff -u -p -u -p -r1.196 linux-nat.c
>> --- linux-nat.c 27 Feb 2011 16:25:37 -0000 1.196
>> +++ linux-nat.c 1 Mar 2011 00:39:00 -0000
>> @@ -2198,8 +2198,6 @@ linux_handle_extended_wait (struct lwp_i
>> if (event == PTRACE_EVENT_FORK
>> && linux_fork_checkpointing_p (GET_PID (lp->ptid)))
>> {
>> - struct fork_info *fp;
>> -
>> /* Handle checkpointing by linux-fork.c here as a special
>> case. We don't want the follow-fork-mode or 'catch fork'
>> to interfere with this. */
>> @@ -2209,9 +2207,8 @@ linux_handle_extended_wait (struct lwp_i
>> detach_breakpoints (new_pid);
>>
>> /* Retain child fork in ptrace (stopped) state. */
>> - fp = find_fork_pid (new_pid);
>> - if (!fp)
>> - fp = add_fork (new_pid);
>> + if (!find_fork_pid (new_pid))
>> + add_fork (new_pid);
>>
>> /* Report as spurious, so that infrun doesn't want to follow
>> this fork. We're actually doing an infcall in
>