From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16861 invoked by alias); 1 Mar 2011 02:33:22 -0000 Received: (qmail 16853 invoked by uid 22791); 1 Mar 2011 02:33:21 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 02:33:12 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 1788228004; Mon, 28 Feb 2011 18:33:11 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 0EF7DCD963; Mon, 28 Feb 2011 18:33:11 -0800 (PST) Message-ID: <4D6C5AE6.2000007@vmware.com> Date: Tue, 01 Mar 2011 02:33:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: David Daney CC: "gdb-patches@sourceware.org" Subject: Re: [commit] linux-nat.c, linux_handle_extended_wait: delete unused variable References: <4D6C40CC.6010900@vmware.com> <4D6C5533.80609@caviumnetworks.com> In-Reply-To: <4D6C5533.80609@caviumnetworks.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00012.txt.bz2 David Daney wrote: > On 02/28/2011 04:41 PM, Michael Snyder wrote: >> checked in. >> >> >> >> 2011-02-28 Michael Snyder >> >> * linux-nat.c (linux_handle_extended_wait): Delete unused variable. > > I'm probably being pedantic, but that is not entirely accurate in this > case. It is more like: > > Rewrite by nesting expressions to use fewer declared variables. I'll change it if you really want... >> Index: linux-nat.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/linux-nat.c,v >> retrieving revision 1.196 >> diff -u -p -u -p -r1.196 linux-nat.c >> --- linux-nat.c 27 Feb 2011 16:25:37 -0000 1.196 >> +++ linux-nat.c 1 Mar 2011 00:39:00 -0000 >> @@ -2198,8 +2198,6 @@ linux_handle_extended_wait (struct lwp_i >> if (event == PTRACE_EVENT_FORK >> && linux_fork_checkpointing_p (GET_PID (lp->ptid))) >> { >> - struct fork_info *fp; >> - >> /* Handle checkpointing by linux-fork.c here as a special >> case. We don't want the follow-fork-mode or 'catch fork' >> to interfere with this. */ >> @@ -2209,9 +2207,8 @@ linux_handle_extended_wait (struct lwp_i >> detach_breakpoints (new_pid); >> >> /* Retain child fork in ptrace (stopped) state. */ >> - fp = find_fork_pid (new_pid); >> - if (!fp) >> - fp = add_fork (new_pid); >> + if (!find_fork_pid (new_pid)) >> + add_fork (new_pid); >> >> /* Report as spurious, so that infrun doesn't want to follow >> this fork. We're actually doing an infcall in >