From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "drow@false.org" <drow@false.org>
Subject: [RFA] Fix memory leak in gdbserver/hostio.c
Date: Sun, 27 Feb 2011 00:40:00 -0000 [thread overview]
Message-ID: <4D699B2E.3020107@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 20 bytes --]
Found by coverity.
[-- Attachment #2: hostio.txt --]
[-- Type: text/plain, Size: 610 bytes --]
2011-02-26 Michael Snyder <msnyder@vmware.com>
* hostio.c (handle_pwrite): Free alloced buffer on early return.
Index: hostio.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/hostio.c,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 hostio.c
--- hostio.c 1 Jan 2011 15:33:24 -0000 1.11
+++ hostio.c 27 Feb 2011 00:27:20 -0000
@@ -367,6 +367,7 @@ handle_pwrite (char *own_buf, int packet
|| require_data (p, packet_len - (p - own_buf), &data, &len))
{
hostio_packet_error (own_buf);
+ free (data);
return;
}
next reply other threads:[~2011-02-27 0:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 0:40 Michael Snyder [this message]
2011-02-27 17:10 ` Pedro Alves
2011-02-27 21:57 ` Michael Snyder
2011-02-27 23:29 ` Pedro Alves
2011-02-28 4:39 ` [commit] Compilation regression [Re: [RFA] Fix memory leak in gdbserver/hostio.c] Jan Kratochvil
2011-02-28 16:00 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D699B2E.3020107@vmware.com \
--to=msnyder@vmware.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox