From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1248 invoked by alias); 27 Feb 2011 00:30:44 -0000 Received: (qmail 1240 invoked by uid 22791); 27 Feb 2011 00:30:43 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Feb 2011 00:30:40 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 064791C002; Sat, 26 Feb 2011 16:30:39 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 012E6C9FC3; Sat, 26 Feb 2011 16:30:39 -0800 (PST) Message-ID: <4D699B2E.3020107@vmware.com> Date: Sun, 27 Feb 2011 00:40:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" CC: "drow@false.org" Subject: [RFA] Fix memory leak in gdbserver/hostio.c Content-Type: multipart/mixed; boundary="------------030804070506070300010301" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00820.txt.bz2 This is a multi-part message in MIME format. --------------030804070506070300010301 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 20 Found by coverity. --------------030804070506070300010301 Content-Type: text/plain; name="hostio.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="hostio.txt" Content-length: 610 2011-02-26 Michael Snyder * hostio.c (handle_pwrite): Free alloced buffer on early return. Index: hostio.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/hostio.c,v retrieving revision 1.11 diff -u -p -u -p -r1.11 hostio.c --- hostio.c 1 Jan 2011 15:33:24 -0000 1.11 +++ hostio.c 27 Feb 2011 00:27:20 -0000 @@ -367,6 +367,7 @@ handle_pwrite (char *own_buf, int packet || require_data (p, packet_len - (p - own_buf), &data, &len)) { hostio_packet_error (own_buf); + free (data); return; } --------------030804070506070300010301--