From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>, "drow@false.org" <drow@false.org>
Subject: Re: [RFA] Fix memory leak in gdbserver/hostio.c
Date: Sun, 27 Feb 2011 17:10:00 -0000 [thread overview]
Message-ID: <201102271705.43466.pedro@codesourcery.com> (raw)
In-Reply-To: <4D699B2E.3020107@vmware.com>
On Sunday 27 February 2011 00:30:38, Michael Snyder wrote:
> Found by coverity.
Do you try running coverity on your patches?
> @@ -367,6 +367,7 @@ handle_pwrite (char *own_buf, int packet
> || require_data (p, packet_len - (p - own_buf), &data, &len))
> {
> hostio_packet_error (own_buf);
> + free (data);
> return;
> }
This is wrong. If any predicate other than require_data in if above
returned true, then you'll be freeing a garbage pointer. I'd
fix this in require_data ... just free the output buffer when
returning error, so the callers never have to.
--
Pedro Alves
next prev parent reply other threads:[~2011-02-27 17:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 0:40 Michael Snyder
2011-02-27 17:10 ` Pedro Alves [this message]
2011-02-27 21:57 ` Michael Snyder
2011-02-27 23:29 ` Pedro Alves
2011-02-28 4:39 ` [commit] Compilation regression [Re: [RFA] Fix memory leak in gdbserver/hostio.c] Jan Kratochvil
2011-02-28 16:00 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102271705.43466.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox