From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11401 invoked by alias); 27 Feb 2011 17:05:59 -0000 Received: (qmail 11393 invoked by uid 22791); 27 Feb 2011 17:05:59 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Feb 2011 17:05:55 +0000 Received: (qmail 31808 invoked from network); 27 Feb 2011 17:05:53 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Feb 2011 17:05:53 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Fix memory leak in gdbserver/hostio.c Date: Sun, 27 Feb 2011 17:10:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Michael Snyder , "drow@false.org" References: <4D699B2E.3020107@vmware.com> In-Reply-To: <4D699B2E.3020107@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201102271705.43466.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00835.txt.bz2 On Sunday 27 February 2011 00:30:38, Michael Snyder wrote: > Found by coverity. Do you try running coverity on your patches? > @@ -367,6 +367,7 @@ handle_pwrite (char *own_buf, int packet > || require_data (p, packet_len - (p - own_buf), &data, &len)) > { > hostio_packet_error (own_buf); > + free (data); > return; > } This is wrong. If any predicate other than require_data in if above returned true, then you'll be freeing a garbage pointer. I'd fix this in require_data ... just free the output buffer when returning error, so the callers never have to. -- Pedro Alves