From: Yao Qi <yao@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Move common macros to i386-common.h
Date: Thu, 24 Feb 2011 04:32:00 -0000 [thread overview]
Message-ID: <4D65DAFF.9050603@codesourcery.com> (raw)
In-Reply-To: <201102232117.p1NLHdhA015543@glazunov.sibelius.xs4all.nl>
On 02/24/2011 05:17 AM, Mark Kettenis wrote:
> I'm particularly worried about changes I'll make myself. My primary
> development platform is OpenBSD which isn't supported by gdbserver.
> So I won't be building the gdbserver code, so I won't notice any
> problems my diffs (and other people's diffs) will introduce in
> gdbserver.
>
Everyone here can only test his/her diff on a limited number of
combination of arch and os. If diff breaks gdb or gdbserver, it should
be fixed.
> Sharing architecture-specific #define's is probably fine. Sharing
> some simple basec support functions may also be ok. But I don't think
> sharing more complicated code (such as the code manipulating the i386
> debug registers) is a good idea.
To my patch, it is like an equivalent transformation. Code moved in gdb
and gdbserver are exactly 100% same. AFAICS, i386 debug register
manipulation code is the same on gdb and gdbserver. Why do you think it
is not a good idea to move them? Am I missing something?
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-02-24 4:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 9:58 Yao Qi
2011-02-13 13:40 ` Mark Kettenis
2011-02-17 6:36 ` Yao Qi
2011-02-17 6:41 ` Joel Brobecker
2011-02-17 18:15 ` Jan Kratochvil
2011-02-23 5:36 ` Yao Qi
2011-02-23 21:35 ` Mark Kettenis
2011-02-24 4:32 ` Yao Qi [this message]
2011-02-24 5:11 ` Joel Brobecker
2011-02-28 18:12 ` Tom Tromey
2011-03-11 6:39 ` [try 2nd, patch] Move common macros to i386-dbg-reg.h Yao Qi
2011-03-29 7:54 ` Yao Qi
2011-04-07 14:07 ` Yao Qi
2011-04-07 15:54 ` Mark Kettenis
2011-04-11 2:01 ` Yao Qi
2011-04-13 17:05 ` Joel Brobecker
2011-04-13 18:48 ` Jan Kratochvil
2011-04-14 8:05 ` Yao Qi
2011-04-25 11:03 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D65DAFF.9050603@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox