From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: yao@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [try 2nd, patch] Move common macros to i386-dbg-reg.h
Date: Thu, 07 Apr 2011 15:54:00 -0000 [thread overview]
Message-ID: <201104071553.p37FrP3T016810@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <4D9DC513.6040403@codesourcery.com> (message from Yao Qi on Thu, 07 Apr 2011 22:07:15 +0800)
> Date: Thu, 07 Apr 2011 22:07:15 +0800
> From: Yao Qi <yao@codesourcery.com>
>
> On 03/29/2011 01:02 PM, Yao Qi wrote:
> > On 03/11/2011 01:05 PM, Yao Qi wrote:
> >> Compared with last version, two changes are in this new patch,
> >> 1) rename i386-common.h to i386-dbg-reg.h,
> >> 2) add dependency tracking in gdbserver.
> >>
> >> OK for mainline after 7.3 branch is created?
> >>
> >> gdb/
> >>
> >> * i386-nat.h: Include i386-dbg-reg.h.
> >> Move macros to i386-dbg-reg.h.
> >> * i386-nat.c: Move macros and structs to i386-dbg-reg.h.
> >> New variable struct i386_debug_reg_state state to replace
> >> other variables dr_mirror, dr_ref_count, dr_control_mirror,
> >> and dr_status_mirror.
> >> (i386_insert_aligned_watchpoint): Add one formal parameter
> >> struct i386_debug_reg_state *STATE.
> >> Update code using these variables.
> >> (i386_remove_aligned_watchpoint, i386_show_dr): Likewise.
> >> (i386_cleanup_dregs): Likewise.
> >> (i386_handle_nonaligned_watchpoint): Likewise.
> >> * common/i386-dbg-reg.h: New. Common macros and structs.
> >>
> >> gdb/gdbserver/
> >>
> >> * i386-low.h: Include i386-dbg-reg.h.
> >> Move macros to i386-dbg-reg.h.
> >> * i386-low.c (i386_set_debug_register_length): New.
> >> (i386_low_init_dregs): Call i386_set_debug_register_length.
> >> * Makefile.in (i386_low_h) Depends on i386-dbg-reg.h.
> >
> > Ping.
> >
>
> Ping?
Sorry, but as long as there is no clear vision of what gdbsever should
be (a fully featured native GDB replacement or a lightweight remote
protocol stub) and how to handle the configure mess, I'm hesitant to
review diffs.
Also, posting pings without a pointer to the actual diff isn't helping
either.
next prev parent reply other threads:[~2011-04-07 15:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 9:58 [patch] Move common macros to i386-common.h Yao Qi
2011-02-13 13:40 ` Mark Kettenis
2011-02-17 6:36 ` Yao Qi
2011-02-17 6:41 ` Joel Brobecker
2011-02-17 18:15 ` Jan Kratochvil
2011-02-23 5:36 ` Yao Qi
2011-02-23 21:35 ` Mark Kettenis
2011-02-24 4:32 ` Yao Qi
2011-02-24 5:11 ` Joel Brobecker
2011-02-28 18:12 ` Tom Tromey
2011-03-11 6:39 ` [try 2nd, patch] Move common macros to i386-dbg-reg.h Yao Qi
2011-03-29 7:54 ` Yao Qi
2011-04-07 14:07 ` Yao Qi
2011-04-07 15:54 ` Mark Kettenis [this message]
2011-04-11 2:01 ` Yao Qi
2011-04-13 17:05 ` Joel Brobecker
2011-04-13 18:48 ` Jan Kratochvil
2011-04-14 8:05 ` Yao Qi
2011-04-25 11:03 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104071553.p37FrP3T016810@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox