From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [patch] Move common macros to i386-common.h
Date: Thu, 17 Feb 2011 06:41:00 -0000 [thread overview]
Message-ID: <20110217063641.GC15527@adacore.com> (raw)
In-Reply-To: <4D5CBF2D.9020101@codesourcery.com>
> w.r.t this specific patch, its "potential benefit" is that, some
> duplicated functions (i386_length_and_rw_bits, and
> i386_{insert|remove}_aligned_watchpoint) in i386-nat.c and
> gdbserver/i386-low.c can be merged together. Please take this into account.
Thinking beyond that, I think that GDB should conceptualy contain
a internal GDBserver. That way, when we port GDB to an architecture,
we're pretty much porting GDBserver as well, for free. And when
someone only ported GDBserver at one point, we don't need to redo
that work when porting GDB itself.
--
Joel
next prev parent reply other threads:[~2011-02-17 6:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 9:58 Yao Qi
2011-02-13 13:40 ` Mark Kettenis
2011-02-17 6:36 ` Yao Qi
2011-02-17 6:41 ` Joel Brobecker [this message]
2011-02-17 18:15 ` Jan Kratochvil
2011-02-23 5:36 ` Yao Qi
2011-02-23 21:35 ` Mark Kettenis
2011-02-24 4:32 ` Yao Qi
2011-02-24 5:11 ` Joel Brobecker
2011-02-28 18:12 ` Tom Tromey
2011-03-11 6:39 ` [try 2nd, patch] Move common macros to i386-dbg-reg.h Yao Qi
2011-03-29 7:54 ` Yao Qi
2011-04-07 14:07 ` Yao Qi
2011-04-07 15:54 ` Mark Kettenis
2011-04-11 2:01 ` Yao Qi
2011-04-13 17:05 ` Joel Brobecker
2011-04-13 18:48 ` Jan Kratochvil
2011-04-14 8:05 ` Yao Qi
2011-04-25 11:03 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217063641.GC15527@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox