From: Michael Snyder <msnyder@vmware.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] Shorten lines of >= 80 columns.
Date: Thu, 06 Jan 2011 18:05:00 -0000 [thread overview]
Message-ID: <4D26046B.5060003@vmware.com> (raw)
In-Reply-To: <20110106043158.GB28888@adacore.com>
Joel Brobecker wrote:
>> internal_error (__FILE__, __LINE__,
>> _("gen_var_ref: LOC_CONST_BYTES "
>> "symbols are not supported"));
>
> For one-line strings, I think that's an acceptable solution. In fact,
> this might be a better solution, making the code as a whole more
> readable (because it avoids the misindentation of the string that breaks
> the formatting of the code as a whole).
>
> For multi-line strings, such as help strings, etc, I think it will be
> easier to still use the style that you originally chose. For instance:
>
> | warning (_("\
> | Private mapping of shared library text was not specified\n\
> | by the executable; setting a breakpoint in a shared library which\n\
> | is not privately mapped will not work. See the HP-UX 11i v3 chatr\n\
> | manpage for methods to privately map shared library text."));
>
> I think that, for multi-line strings, this makes easier to read the
> entire text, and it also makes it easier to make sure that the string
> is of reasonable size (ie, under 80, or 76, or 74).
>
> The typical case where these are used are the _init routines, where
> we create new commands. The help strings can easily need to have
> more than one line (if it was me, I would put as much information
> in the help command as in the manual).
Yeah, you're right. I'll try to put some of them back.
next prev parent reply other threads:[~2011-01-06 18:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 19:10 Michael Snyder
2011-01-04 19:19 ` Pierre Muller
2011-01-04 20:00 ` Michael Snyder
2011-01-05 9:02 ` Pierre Muller
2011-01-05 18:25 ` Michael Snyder
2011-01-05 21:38 ` Michael Snyder
2011-01-06 4:32 ` Joel Brobecker
2011-01-06 18:05 ` Michael Snyder [this message]
2011-01-04 19:27 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D26046B.5060003@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox