Re: [patch] Shorten lines of >= 80 columns.

[Michael Snyder <msnyder@vmware.com>]

Pierre Muller wrote:
> I thought that they were already considered as obvious,
> but I still have a remark about one of your
> changes:
> 
> @@ -632,8 +633,8 @@ gen_var_ref (struct gdbarch *gdbarch, st
>        break;
>  
>      case LOC_CONST_BYTES:
> -      internal_error (__FILE__, __LINE__,
> -		      _("gen_var_ref: LOC_CONST_BYTES symbols are not
> supported"));
> +      internal_error (__FILE__, __LINE__, _("\
> +gen_var_ref: LOC_CONST_BYTES symbols are not supported"));
> 
> I think this kind of changes confuses cvs
> for the 'cvs diff -u -p':
> it might regard the new line
> +gen_var_ref: LOC_CONST_BYTES symbols are not supported"));
> as a new starting function line and
> report a wrong function name...
> Of course not really for your example here,
> as the start of the line is
> the name of the function itself...
> But I remember having seen
> wrong function name reported with 'cvs -u -p'
> due to the use of '_("\'
> construct which force starting next line without 
> spaces...
> 
> Pierre Muller
> GDB pascal language maintainer


Hmmm... well, we already have tons of similar constructs in the tree.