From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-77398-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31100 invoked by alias); 4 Jan 2011 20:00:50 -0000
Received: (qmail 31092 invoked by uid 22791); 4 Jan 2011 20:00:49 -0000
X-SWARE-Spam-Status: No, hits=-4.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Jan 2011 20:00:44 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id D991B2F00B;	Tue,  4 Jan 2011 12:00:42 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost4.vmware.com (Postfix) with ESMTP id CE61AC9AC1;	Tue,  4 Jan 2011 12:00:42 -0800 (PST)
Message-ID: <4D237C6A.9050609@vmware.com>
Date: Tue, 04 Jan 2011 20:00:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] Shorten lines of >= 80 columns.
References: <4D237089.1080309@vmware.com> <000c01cbac44$48830210$d9890630$@muller@ics-cnrs.unistra.fr>
In-Reply-To: <000c01cbac44$48830210$d9890630$@muller@ics-cnrs.unistra.fr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-01/txt/msg00066.txt.bz2

Pierre Muller wrote:
> I thought that they were already considered as obvious,
> but I still have a remark about one of your
> changes:
> 
> @@ -632,8 +633,8 @@ gen_var_ref (struct gdbarch *gdbarch, st
>        break;
>  
>      case LOC_CONST_BYTES:
> -      internal_error (__FILE__, __LINE__,
> -		      _("gen_var_ref: LOC_CONST_BYTES symbols are not
> supported"));
> +      internal_error (__FILE__, __LINE__, _("\
> +gen_var_ref: LOC_CONST_BYTES symbols are not supported"));
> 
> I think this kind of changes confuses cvs
> for the 'cvs diff -u -p':
> it might regard the new line
> +gen_var_ref: LOC_CONST_BYTES symbols are not supported"));
> as a new starting function line and
> report a wrong function name...
> Of course not really for your example here,
> as the start of the line is
> the name of the function itself...
> But I remember having seen
> wrong function name reported with 'cvs -u -p'
> due to the use of '_("\'
> construct which force starting next line without 
> spaces...
> 
> Pierre Muller
> GDB pascal language maintainer


Hmmm... well, we already have tons of similar constructs in the tree.